REPL Telemetry for Terminal REPL and Native REPL - #23941
Merged
Anthony Kim (anthonykim1) merged 4 commits intoAug 13, 2024
Merged
Anthony Kim (anthonykim1) merged 4 commits into
Anthony Kim (anthonykim1) merged 4 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
TylerLeonhardt
previously approved these changes
Aug 12, 2024
Comment thread
src/client/terminals/codeExecution/terminalReplWatcher.ts
Outdated
Co-authored-by: Karthik Nadig <kanadig@microsoft.com>
Anthony Kim (anthonykim1)
requested review from
TylerLeonhardt and
Karthik Nadig (karthiknadig)
August 13, 2024 06:18
Comment thread
src/client/terminals/codeExecution/terminalReplWatcher.ts
Outdated
Karthik Nadig (karthiknadig)
approved these changes
Aug 13, 2024
Anthony Kim (anthonykim1)
added a commit
that referenced
this pull request
Aug 13, 2024
Related to #23740 In addition to : #23941 Fire telemetry for when REPL is launched via shift+enter. /cc @cwebster-99
Anthony Kim (anthonykim1)
added a commit
that referenced
this pull request
Aug 16, 2024
#23941 Having no blank spaces in front of plain 'python' or 'python3' were returning falsey value.
Anthony Kim (anthonykim1)
added a commit
to anthonykim1/vscode-python
that referenced
this pull request
Sep 13, 2024
microsoft#23941 Having no blank spaces in front of plain 'python' or 'python3' were returning falsey value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
Assignees
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #23740
Also organize Telemetry for Terminal REPL vs. Native REPL.
Now we can sort them out with new attribute 'replType' on the REPL Event.
With this PR: