Fix telemetry not getting picked up for Terminal REPL - #23958
Merged
Anthony Kim (anthonykim1) merged 3 commits intoAug 16, 2024
Merged
Anthony Kim (anthonykim1) merged 3 commits into
Anthony Kim (anthonykim1) merged 3 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Anthony Kim (anthonykim1)
marked this pull request as ready for review
August 16, 2024 20:17
Justin Chen (justschen)
previously approved these changes
Aug 16, 2024
Anthony Kim (anthonykim1)
enabled auto-merge (squash)
August 16, 2024 20:33
Anthony Kim (anthonykim1)
marked this pull request as draft
August 16, 2024 20:39
auto-merge was automatically disabled
August 16, 2024 20:39
Pull request was converted to draft
Justin Chen (justschen)
previously approved these changes
Aug 16, 2024
Anthony Kim (anthonykim1)
marked this pull request as ready for review
August 16, 2024 20:56
Anthony Kim (anthonykim1)
enabled auto-merge (squash)
August 16, 2024 20:56
Justin Chen (justschen)
approved these changes
Aug 16, 2024
Closed
Anthony Kim (anthonykim1)
added a commit
to anthonykim1/vscode-python
that referenced
this pull request
Sep 13, 2024
microsoft#23941 Having no blank spaces in front of plain 'python' or 'python3' were returning falsey value.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#23941
Having no blank spaces in front of plain 'python' or 'python3' were returning falsey value.
Also comply to new ruff rule.