Repository navigation
Fix clean up sse disconnect event (not upgrade lib) - #703
Closed
lcamhoa wants to merge 5 commits into
Closed
lcamhoa wants to merge 5 commits into
lcamhoa wants to merge 5 commits into
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
3 of 9 tasks
lcamhoa
force-pushed
the
main-sse-disconnect
branch
from
d543469 to
7de20f5
Compare
May 13, 2025 13:23
Copy link
Copy Markdown
Author
Sorry, something went wrong.
Copy link
Copy Markdown
|
Was the session clean-up included in #612? @lcamhoa @akash329d After a session is disconnected: 
The next message triggers a ConnectionClosedException, which makes sense since the session stream was closed? 
I would have expected e.g. a "404 could not find session" error instead of an exception. |
Sorry, something went wrong.
tomconte
added a commit
to tomconte/python-sdk
that referenced
this pull request
Jul 31, 2025
2 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
When SSE Connection disconnect , we should clean up memory by session id
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context