resetDecoder should be called once per decoding - #387
Conversation
Sorry, something went wrong.
| this.sequence = checkNotNull(sequence, "input sequence is null"); | ||
| try { | ||
| nextInput(); | ||
| } catch (IOException ignore) { |
There was a problem hiding this comment.
code style check error: https://travis-ci.org/msgpack/msgpack-java/jobs/162190720#L507
Sorry, something went wrong.
| } | ||
|
|
||
| "read numeric data at buffer boundary" taggedAs("boundary2") in { | ||
| "read data at buffer boundary" taggedAs("boundary2") in { |
There was a problem hiding this comment.
This test case is intended for checking a bug on unpackInteger that found in the past. We should have another test case for string.
Sorry, something went wrong.
| private Enumeration<? extends MessageBufferInput> sequence; | ||
| private MessageBufferInput input; | ||
|
|
||
| public SequenceMessageBufferInput(Enumeration<? extends MessageBufferInput> sequence) |
There was a problem hiding this comment.
can we use Iterator, Stream, Iterable, or Collection instead of Enumeration? or how about moving this to test package only for now? Because Enumeration is considered as a deprecated interface used only by old classes such as Vector or Hashtable.
Sorry, something went wrong.
There was a problem hiding this comment.
Agreed. Iterator<MessageBufferInput> would work. And this should be in test package.
Sorry, something went wrong.
When multiple MessageBuffer involved at unpackString first bytes can be removed because resetDecoder is called multiple times.