Need to auto-detect Node-Webkit (npm install nodegit not working) #212
Description
Activity
Does it actually complete? That doesn't look like all of the message. Does require("nodegit") work? That is an expected failure in some cases.
Edit: Is that a black crappie?
Thanks for the quick reply! Yeah the pastebin is the 20 or so lines around the failure. this is the whole thing: http://pastebin.com/bTCQQQTv
npm install npm install git://github.com/tbranyen/nodegit.git
complains about not having ejsafter npm install ejs that same command works to install but then
"Uncaught Error: ENOENT, no such file or directory 'node_modules/nodegit/index.js'"and yes! one of the bigger ones that day
edit: also caught this that same weekend
https://dl.dropboxusercontent.com/u/42766757/411818_3450532743680_698577903_o.jpgHrm, can you try?
npm install git://github.com/nodegit/nodegit.git
Same thing. It complains about ejs and when ejs is there "Uncaught Error: ENOENT, no such file or directory 'node_modules/nodegit/index.js'"
A few more things I've tried. I have a copy of index.js that looks like http://pastebin.com/0gc6ssQz
I've put that into the folder and get the error
Uncaught Error: Cannot find module './build/Debug/nodegitif I remove the try blocks around "rawApi = require('./build/Release/nodegit');" I get
Uncaught Error: dlopen(node_modules/nodegit/build/Release/nodegit.node, 1): no suitable image found. Did find: node_modules/nodegit/build/Release/nodegit.node: mach-o, but wrong architectureI forgot to mention that I'm running this in node-webkit.. which ended up being important.
I fixed by installing nw-gyp and running nw-gyp rebuild --target=0.8.6 inside nodegit.
Hey! So we're trying to get this package loaded in a git project we're building (same setup: node-webkit) and we're basically getting the same error that @pnispel was getting. I'm about to try this above solution to see if it works for us.
Interesting, if nw-gyp works for you, we should look into conditionally building for that target.
So I'm a fairly recently converting from .NET dev to Mac/node/webkit style dev so it's quite possible that I'm missing something easy.
Here's what I've tried:
- Installed nw-gyp by doing sudo npm install -g nw-gyp and also installed all dependencies.
- Cloned the repo using git clone
- Ran nw-gyp rebuild --target=0.8.6 Which gave me:
So that led me down a path of creating a binding.gyp file in nodegit/ according to what's outlined here.
So my binding.gyp file looks like this:
{ "targets": [ { "target_name": "nodegit", "sources": [ "src/wrapper.cc" ] } ] }Now running the same command nw-gyp command gives me:
So I'm not sure if I'm heading down the wrong path here or if I'm missing some simple since I'm relatively new to osx or what. Any ideas? @pnispel what exactly did you do to get nw-gyp to work?
@johnhaley81 the target parameter of nw-gyp rebuild --target=0.8.6 is the version of node-webkit you are using. check out this for getting the version
@johnhaley81 just to clarify. i believe the full process i used was:
- npm install git://github.com/tbranyen/nodegit.git
- npm install ejs
- cd node_modules/nodegit
- nw-gyp rebuild --target=TARGET
You don't create any binding.gyp files, we dynamically create it. Try running:
npm run generate
This should create the file you need. I'm not sure about the --target flag. Looks very wrong, I would omit it, unless you can research more as to what that version means.
@pnispel That target thing worked great. Now here's something interesting. When I use
sudo nw-gyp rebuild --target=0.8.6
it builds just fine (bash log).
It does not however work in my application. I'm getting that same error (wrong architecture) that I was getting before which is unfortunate.
Now I have the target set to what my application is using (0.9.2) and it doesn't rebuild without errors (bash log).
The exact command I'm sending in is
sudo nw-gyp rebuild --target=0.9.2
Any ideas?
@johnhaley81 I'd check your version of node as per here. I'm using v0.10.28 without problems. Other than that I'm not sure. You could try getting an older version of node-webkit 0.8.6 or something too I suppose.
@pnispel I'm on v0.10.30 of node. I'm looking into switching versions of node-webkit now to see if that will fix the issue.
so I have v0.9.2 working, along with 0.10.2. (In the same project as @johnhaley81 ). The issue there was something silly with how our directory structure was set up (our project was putting other versions of node webkit in incorrect dirs).
nw-gyp works perfect though per the process @pnispel specified above, so perhaps conditionally building is the way to go. I have no clue how to set any of that up (I'm new to this too), but I'd be happy to help if someone can point me in the right direction.
@tbranyen hey so @maxkorp and I are able/willing to work full time on getting this and #136 up and running if you can point us in the right direction.
We're going to be heavily using this code in a project so we can dedicate a good amount of time bring it up to have SSH and some more interfaces into libgit2.
We both have been poking around to see how you're generating the interface into libgit2 so we'll try to get caught up on that right now. Also checking out all of the open issues and PR's you've had over the last few months to see what's been happening. Any other ideas on what else we should look at?
- changed the title [-]npm install nodegit not working[/-] [+]Need to auto-detect Node-Webkit (npm install nodegit not working)[/+] on Oct 24, 2014
Now that @johnhaley81 and I have half a clue how this all works, gonna try and fix this.
So nw-gyp requires a --target argument with the node webkit version. I was thinking of attempting to look at the engines in package.json, and if they specify node-webkit, trying to match by either semver globbing, and falling back to the latest stable (if it fails or they dont specify a version). Thoughts? I suppose it wouldnt work if nodegit got used in another package, which was then used in node-webkit land though. Perhaps this issue is upstream? Maybe there needs to be a way to force using nw-gyp instead of node-gyp for a system build, agnostic of what its building.
Relevant stackover question: http://stackoverflow.com/questions/27154941/detecting-node-webkit-during-npm-install
- added this to the milestone on Nov 26, 2014
This should finally be fixed with the pull request referenced above.
OSX 10.9.4
npm install nodegit
http://pastebin.com/gkcHvsa2
using the building from source instructions
"Uncaught Error: ENOENT, no such file or directory 'node_modules/nodegit/index.js'"
nodegit is there, just index.js is not
one time i was able to get nodegit to build and it had an index.js, unable to recreate though.
and when this happened it was unable to find the 'build/Debug/nodegit' module