Use wider int to calculate throttle window - #1232
Merged
johnhaley81 merged 1 commit intoFeb 28, 2017
Merged
johnhaley81 merged 1 commit into
johnhaley81 merged 1 commit into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Not totally sure why, but this is killing linux 32-bit. |
Sorry, something went wrong.
johnhaley81
force-pushed
the
throttle-overflow-fix
branch
from
981bea6 to
c018da1
Compare
February 28, 2017 15:15
Copy link
Copy Markdown
Collaborator
|
32-bit linux dieing was unrelated and fixed in #1241 |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sufficiently large throttle values would cause an overflow - the cast coerces the computation into a sufficiently large int