Fix linux 32-bit builds - #1241
Merged
johnhaley81 merged 2 commits intoFeb 28, 2017
Merged
johnhaley81 merged 2 commits into
johnhaley81 merged 2 commits into
Conversation
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
johnhaley81
force-pushed
the
fix-linux-32
branch
from
e4c331c to
d912e1c
Compare
February 28, 2017 13:32
johnhaley81
force-pushed
the
fix-linux-32
branch
from
d912e1c to
e3fd303
Compare
February 28, 2017 13:44
Copy link
Copy Markdown
Collaborator
Author
|
The builds were failing because somehow the sudo: required broke downloading packages off of apt-get (?!?) so removing that makes the build work again. sudo was required because in order to build NodeGit on 32-bit linux we required a symlink to work around a bug introduced in gcc-multilib that renamed /usr/include/asm to /usr/include/asm-generic. That appears to be fixed so the work-around was no longer needed. As an extra measure I added back in testing 32-bit builds for linux as well since they were removed originally. |
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
Author
|
|
Sorry, something went wrong.
This was referenced Feb 28, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.