rules: accept "deps: V8" as the subsystem for revert commits - #102
Merged
RaisinTen merged 1 commit intoOct 25, 2022
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
The commit, nodejs/node@cbb4045, was being flagged as invalid by core-validate-commit because of this error: ```txt Error: not ok 6 title-format: First word after subsystem(s) in title should be lowercase. (Revert "deps: V8: forward declaration of `Rtl*FunctionTable`") ``` This is incorrect because "deps: V8" is a valid subsystem. This change makes sure that revert commits with such a subsystem is accepted. Signed-off-by: Darshan Sen <raisinten@gmail.com>
Copy link
Copy Markdown
Codecov ReportBase: 93.89% // Head: 93.93% // Increases project coverage by +0.03% 🎉 Additional details and impacted files @@ Coverage Diff @@
## main #102 +/- ##
==========================================
+ Coverage 93.89% 93.93% +0.03%
==========================================
Files 19 19
Lines 459 462 +3
==========================================
+ Hits 431 434 +3
Misses 28 28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sorry, something went wrong.
Trott
approved these changes
Oct 22, 2022
RaisinTen
deleted the
rules/accept-deps-V8-as-the-subsystem-for-revert-commits
branch
October 25, 2022 05:44
Copy link
Copy Markdown
Member
Author
|
Released in v3.17.1. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
1 more reviewer2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit, nodejs/node@cbb4045, was being flagged as invalid by core-validate-commit because of this error:
Error: not ok 6 title-format: First word after subsystem(s) in title should be lowercase. (Revert "deps: V8: forward declaration of `Rtl*FunctionTable`")This is incorrect because "deps: V8" is a valid subsystem. This change makes sure that revert commits with such a subsystem is accepted.
Signed-off-by: Darshan Sen raisinten@gmail.com
cc @targos