FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Revert "deps: V8: forward declaration of `Rtl*FunctionTable`" by targos · Pull Request #45119 · nodejs/node · GitHub

/ node Public

Revert "deps: V8: forward declaration of Rtl*FunctionTable" - #45119

Merged
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:revert-rtl
Oct 25, 2022
ConversationCommits (1)ChecksFiles changed
Merged

Revert "deps: V8: forward declaration of Rtl*FunctionTable"#45119
nodejs-github-bot merged 1 commit into
nodejs:mainfrom
targos:revert-rtl

Conversation

targos commented Oct 22, 2022

Copy link
Copy Markdown
Member

This reverts commit 01bc8e6.

Refs: #45118

nodejs-github-bot commented Oct 22, 2022

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/v8-update

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 22, 2022
targos added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 22, 2022

targos commented Oct 22, 2022

Copy link
Copy Markdown
Member Author

Don't we allow git-style revert messages?

targos mentioned this pull request Oct 22, 2022
Closed
7 tasks
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 22, 2022

nodejs-github-bot commented Oct 22, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47388/

gengjiawen commented Oct 22, 2022

Copy link
Copy Markdown
Member

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/4938/

nodejs-github-bot commented Oct 22, 2022

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/4938/

nodejs-github-bot commented Oct 22, 2022

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/4938/

nodejs-github-bot commented Oct 22, 2022

Copy link
Copy Markdown
Collaborator

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/4938/

nodejs-github-bot commented Oct 22, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47389/

RaisinTen commented Oct 22, 2022

Copy link
Copy Markdown
Member

Don't we allow git-style revert messages?

Sounds like a bug to me, I've sent a PR to fix it: nodejs/core-validate-commit#102.

targos commented Oct 22, 2022

Copy link
Copy Markdown
Member Author

Windows CI is green!

nodejs-github-bot commented Oct 22, 2022

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47397/

This was referenced Oct 23, 2022
Open
Open
Open
gengjiawen added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 25, 2022
nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 25, 2022

nodejs-github-bot commented Oct 25, 2022

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/45119
✔  Done loading data for nodejs/node/pull/45119
----------------------------------- PR info ------------------------------------
Title      Revert "deps: V8: forward declaration of `Rtl*FunctionTable`" (#45119)
Author     Michaël Zasso  (@targos)
Branch     targos:revert-rtl -> nodejs:main
Labels     build, v8 engine, needs-ci
Commits    1
 - Revert "deps: V8: forward declaration of `Rtl*FunctionTable`"
Committers 1
 - Michaël Zasso 
PR-URL: https://github.com/nodejs/node/pull/45119
Refs: https://github.com/nodejs/node/issues/45118
Reviewed-By: Jiawen Geng 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45119
Refs: https://github.com/nodejs/node/issues/45118
Reviewed-By: Jiawen Geng 
Reviewed-By: Colin Ihrig 
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 22 Oct 2022 08:28:52 GMT
   ✔  Approvals: 3
   ✔  - Jiawen Geng (@gengjiawen): https://github.com/nodejs/node/pull/45119#pullrequestreview-1151903319
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/45119#pullrequestreview-1151981244
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/45119#pullrequestreview-1152057526
   ✖  Last GitHub CI failed
   ℹ  Last Full PR CI on 2022-10-22T16:51:58Z: https://ci.nodejs.org/job/node-test-pull-request/47397/
   ℹ  Last V8 CI on 2022-10-22T09:35:01Z: https://ci.nodejs.org/job/node-test-commit-v8-linux/4938/
- Querying data for job/node-test-pull-request/47397/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3317858880

RaisinTen approved these changes Oct 25, 2022
View reviewed changes

RaisinTen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Reran the lint-commit-message job after releasing nodejs/core-validate-commit#102 and GitHub CI is green now, LGTM.

RaisinTen removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Oct 25, 2022
RaisinTen added author ready PRs that have at least one approval, no outstanding review comments, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 25, 2022
nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 25, 2022
nodejs-github-bot merged commit c6c18a9 into nodejs:main Oct 25, 2022

nodejs-github-bot commented Oct 25, 2022

Copy link
Copy Markdown
Collaborator

Landed in c6c18a9

targos deleted the revert-rtl branch October 25, 2022 06:02
github-actions Bot mentioned this pull request Oct 26, 2022
Open
14 tasks
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
Revert "deps: V8: forward declaration of Rtl*FunctionTable"
983bc57 
This reverts commit 01bc8e6.

PR-URL: #45119
Refs: #45118
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
RafaelGSS mentioned this pull request Nov 1, 2022
Merged
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
Revert "deps: V8: forward declaration of Rtl*FunctionTable"
0a6ed6f 
This reverts commit 01bc8e6.

PR-URL: #45119
Refs: #45118
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
gengjiawen gengjiawen approved these changes
RaisinTen RaisinTen approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL