Revert "src: ignore GCC -Wcast-function-type for v8.h" · nodejs/node@01d7c46 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 01d7c46

Browse filesBrowse the repository at this point in the historyBrowse files

danbev

authored and

targos

committed

Revert "src: ignore GCC -Wcast-function-type for v8.h"

This reverts commit f21cf45 as this has now been included in the V8 version being used. PR-URL: #35758 Refs: v8/v8@f08cbfd Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

1 parent 6211ffd commit 01d7c46
Copy full SHA for 01d7c46

2 files changed

-14Lines changed: 0 additions & 14 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • string_bytes.h
• test/cctest
  • test_aliased_buffer.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/string_bytes.h‎

Copy file name to clipboardExpand all lines: src/string_bytes.h

-7Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -26,14 +26,7 @@
26	26
27	27	// Decodes a v8::Local<v8::String> or Buffer to a raw char*
28	28
29		- #if (__GNUC__ >= 8) && !defined(__clang__)
30		- #pragma GCC diagnostic push
31		- #pragma GCC diagnostic ignored "-Wcast-function-type"
32		- #endif
33	29	#include "v8.h"
34		- #if (__GNUC__ >= 8) && !defined(__clang__)
35		- #pragma GCC diagnostic pop
36		- #endif
37	30	#include "env-inl.h"
38	31
39	32	#include <string>

Collapse file

‎test/cctest/test_aliased_buffer.cc‎

Copy file name to clipboardExpand all lines: test/cctest/test_aliased_buffer.cc

-7Lines changed: 0 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -1,11 +1,4 @@
1		- #if (__GNUC__ >= 8) && !defined(__clang__)
2		- #pragma GCC diagnostic push
3		- #pragma GCC diagnostic ignored "-Wcast-function-type"
4		- #endif
5	1	#include "v8.h"
6		- #if (__GNUC__ >= 8) && !defined(__clang__)
7		- #pragma GCC diagnostic pop
8		- #endif
9	2	#include "aliased_buffer.h"
10	3	#include "node_test_fixture.h"
11	4

0 commit comments

Comments

0 (0)