Revert "src: ignore GCC -Wcast-function-type for v8.h" - #35758
Closed
danbev wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
This reverts commit f21cf45 as this has now been included in the V8 version being used. Refs: v8/v8@f08cbfd
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
richardlau
approved these changes
Oct 22, 2020
cjihrig
approved these changes
Oct 22, 2020
targos
approved these changes
Oct 22, 2020
Copy link
Copy Markdown
Member
|
Looks like v8/v8@f08cbfd is on V8 8.5 and above so adding appropriate dont-land-on-v* labels. |
Sorry, something went wrong.
gireeshpunathil
approved these changes
Oct 22, 2020
lundibundi
approved these changes
Oct 22, 2020
devnexen
approved these changes
Oct 22, 2020
Copy link
Copy Markdown
Contributor
Author
Yep, we should revert that too. Sorry I forgot about it completely. I'll create a revert for it too. Thanks! |
Sorry, something went wrong.
Trott
approved these changes
Oct 25, 2020
Copy link
Copy Markdown
Contributor
Author
|
Re-run of failing node-test-commit-arm-fanned ✔️ |
Sorry, something went wrong.
danbev
added a commit
that referenced
this pull request
Oct 26, 2020
This reverts commit f21cf45 as this has now been included in the V8 version being used. PR-URL: #35758 Refs: v8/v8@f08cbfd Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 3, 2020
This reverts commit f21cf45 as this has now been included in the V8 version being used. PR-URL: #35758 Refs: v8/v8@f08cbfd Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit f21cf45 as this has
now been included in the V8 version being used.
Refs:
v8/v8@f08cbfd
Checklist