Commit fa6dfec
committed
deps: V8: backport f89e555
Original commit message:
[api] Fix compilation issue with macOS
Fixes the following error caught by the Node.js CI:
../deps/v8/src/api.cc:8943:10:
error: no viable conversion from returned value of type
'unique_ptr<v8::internal::MicrotaskQueue, default_delete<v8::internal::MicrotaskQueue>>'
to function return type
'unique_ptr<v8::MicrotaskQueue, default_delete<v8::MicrotaskQueue>>'
return microtask_queue;
^~~~~~~~~~~~~~~
Change-Id: Ic09dab46bb8f87a2b3b59f5836e0883bfe0e9681
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1627533
Commit-Queue: Michaël Zasso <mic.besace@gmail.com>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Reviewed-by: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#61789}
Refs: v8/v8@f89e555
Backport-PR-URL: #28005
PR-URL: #27375
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 8b8fe87 commit fa6dfec
2 files changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -38,7 +38,7 @@ | |||
| 38 | 38 | ||
| 39 | 39 | # Reset this number to 0 on major V8 upgrades. | |
| 40 | 40 | # Increment by one for each non-official patch applied to deps/v8. | |
| 41 | - 'v8_embedder_string': '-node.5', | ||
| 41 | + 'v8_embedder_string': '-node.6', | ||
| 42 | 42 | ||
| 43 | 43 | ##### V8 defaults for Node.js ##### | |
| 44 | 44 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -8940,7 +8940,8 @@ std::unique_ptr<MicrotaskQueue> MicrotaskQueue::New(Isolate* isolate, | |||
| 8940 | 8940 | auto microtask_queue = | |
| 8941 | 8941 | i::MicrotaskQueue::New(reinterpret_cast<i::Isolate*>(isolate)); | |
| 8942 | 8942 | microtask_queue->set_microtasks_policy(policy); | |
| 8943 | - return microtask_queue; | ||
| 8943 | + std::unique_ptr<MicrotaskQueue> ret(std::move(microtask_queue)); | ||
| 8944 | + return ret; | ||
| 8944 | 8945 | } | |
| 8945 | 8946 | ||
| 8946 | 8947 | MicrotasksScope::MicrotasksScope(Isolate* isolate, MicrotasksScope::Type type) | |
0 commit comments