test: skip test-icu-transcode if ICU is not present - #10707
Closed
watilde wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mscdex
reviewed
Jan 9, 2017
Comment thread
test/parallel/test-icu-transcode.js
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
IMHO I think it would be better to have the skip up here instead. Also, there is already a common.hasIntl that we should be able to re-use:
// ...
const assert = require('assert');
if (!common.hasIntl) {
common.skip('missing intl... skipping test');
return;
}
// ...
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Thanks for your comment! I've updated it.
Sorry, something went wrong.
use common.hasIntl to make sure Intl object is present or not. PR-URL:
watilde
force-pushed
the
feature/fixes-9511
branch
from
02f75dd to
bf731b9
Compare
January 9, 2017 15:40
jasnell
approved these changes
Jan 9, 2017
italoacasas
approved these changes
Jan 9, 2017
Copy link
Copy Markdown
Sorry, something went wrong.
srl295
approved these changes
Jan 16, 2017
srl295
reviewed
Jan 16, 2017
Comment thread
test/parallel/test-icu-transcode.js
| const buffer = require('buffer'); | ||
| const assert = require('assert'); | ||
|
|
||
| if (!common.hasIntl) { |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
we should use this for other test cases. 👍
This way we can easily find the test cases that are Intl dependent.
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Jan 16, 2017
use common.hasIntl to make sure Intl object is present or not. PR-URL: #10707 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
4 tasks
watilde
added a commit
to watilde/node
that referenced
this pull request
Jan 16, 2017
We should use `common.hasIntl` in tests for test cases which are related to ICU. This way we can easily find the test cases that are Intl dependent. Plus, it will be able to make the tests a little faster if we check hasIntl first. Also, this tweaks the log messages to unify the message. Refs: nodejs#10707
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
use common.hasIntl to make sure Intl object is present or not. PR-URL: nodejs#10707 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
lpinca
pushed a commit
that referenced
this pull request
Jan 19, 2017
We should use `common.hasIntl` in tests for test cases which are related to ICU. This way we can easily find the test cases that are Intl dependent. Plus, it will be able to make the tests a little faster if we check hasIntl first. Also, this tweaks the log messages to unify the message. Refs: #10707 PR-URL: #10841 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 23, 2017
use common.hasIntl to make sure Intl object is present or not. PR-URL: nodejs#10707 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 25, 2017
use common.hasIntl to make sure Intl object is present or not. PR-URL: nodejs#10707 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 25, 2017
We should use `common.hasIntl` in tests for test cases which are related to ICU. This way we can easily find the test cases that are Intl dependent. Plus, it will be able to make the tests a little faster if we check hasIntl first. Also, this tweaks the log messages to unify the message. Refs: nodejs#10707 PR-URL: nodejs#10841 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
use common.hasIntl to make sure Intl object is present or not. PR-URL: nodejs#10707 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
We should use `common.hasIntl` in tests for test cases which are related to ICU. This way we can easily find the test cases that are Intl dependent. Plus, it will be able to make the tests a little faster if we check hasIntl first. Also, this tweaks the log messages to unify the message. Refs: nodejs#10707 PR-URL: nodejs#10841 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Copy link
Copy Markdown
Contributor
|
This does not land cleanly in LTS. Please feel free to manually backport |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
ping re: backport |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
I just started working on the backport to v6. |
Sorry, something went wrong.
watilde
added a commit
to watilde/node
that referenced
this pull request
May 8, 2017
use common.hasIntl to make sure Intl object is present or not. PR-URL: nodejs#10707 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
2 tasks
Copy link
Copy Markdown
Member
Author
|
@MylesBorins I'm going to remove the backport-requested-v6.x label from this PR because of this comment: #12905 (comment). Let me know if I misunderstand it. |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9511. Use icu's punycode implementation to make sure ICU is present or not in a test.
Checklist
Affected core subsystem(s)