(v6.x backport) test: skip test-icu-transcode if Intl is not present - #12905
Closed
watilde wants to merge 1 commit into
Closed
(v6.x backport) test: skip test-icu-transcode if Intl is not present#12905watilde wants to merge 1 commit into
watilde wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
use common.hasIntl to make sure Intl object is present or not. PR-URL: nodejs#10707 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
hmm.. unless I'm mistaken, buffer.transcode is not in v6.x at all. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Oh really, then let's stop putting this patch into v6.. Well, this patch will not be called since the CI doesn't have ICU data. It should be fine to not have this patch either. Thanks! |
Sorry, something went wrong.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #10707 to 6.x:
Checklist
Affected core subsystem(s)
test