Build fails on Windows (VS2015): https://ci.nodejs.org/job/node-compile-windows/6598/

It's a bit buried in the sea of warnings but the build error is this:

c1xx : fatal error C1083: Cannot open source file: '..\..\..\build\Release\obj\global_intermediate\src\inspector\protocol\Protocol.cpp': No such file or directory [c:\workspace\node-compile-windows\label\win-vs2015\deps\v8\src\v8_base_0.vcxproj]
  Debugger.cpp
c1xx : fatal error C1083: Cannot open source file: '..\..\..\build\Release\obj\global_intermediate\src\inspector\protocol\Debugger.cpp': No such file or directory [c:\workspace\node-compile-windows\label\win-vs2015\deps\v8\src\v8_base_0.vcxproj]
  Profiler.cpp
c1xx : fatal error C1083: Cannot open source file: '..\..\..\build\Release\obj\global_intermediate\src\inspector\protocol\Profiler.cpp': No such file or directory [c:\workspace\node-compile-windows\label\win-vs2015\deps\v8\src\v8_base_0.vcxproj]
  Schema.cpp
c1xx : fatal error C1083: Cannot open source file: '..\..\..\build\Release\obj\global_intermediate\src\inspector\protocol\Schema.cpp': No such file or directory [c:\workspace\node-compile-windows\label\win-vs2015\deps\v8\src\v8_base_0.vcxproj]

Seems something goes wrong in the generate_inspector_protocol_sources phase.

cc @ofrobots ^
Maybe something missing in node.gyp?

I ran out of day-time and couldn't look at this today. I will try again tomorrow. /cc @eugeneo.

V8 5.6 should become stable next week

I believe that already happened =).

/cc @dgozman

Maybe it's a bug in V8's gypfiles?
See nodejs/help#471 for more details on the error.

@targos I am not sure, but this might be an issue @ofrobots was looking into last week.

5.7 has been released with faster async/await and PromiseHook API. Would it make sense to jump into it ?

@YurySolovyov 5.7 is still in beta phase. We will update to it when Chrome 57 is stable (should be mid-March)

ping @nodejs/v8 for the Windows build issue.

Basically the problem is that deps\v8\src\v8_base_0.vcxproj instructs to look for the inspector generated source files in ..\..\..\build\Release\obj\global_intermediate\src but they are in fact in ..\..\..\Release\obj\global_intermediate\src.

@targos Can you check if this patch helps?

diff --git a/deps/v8/gypfiles/toolchain.gypi b/deps/v8/gypfiles/toolchain.gypi
index 95eb1d9..5105fff 100644
--- a/deps/v8/gypfiles/toolchain.gypi
+++ b/deps/v8/gypfiles/toolchain.gypi
@@ -989,8 +989,6 @@
         #       present in VS 2003 and earlier.
         'msvs_disabled_warnings': [4351],
         'msvs_configuration_attributes': {
-          'OutputDirectory': '<(DEPTH)\\build\\$(ConfigurationName)',
-          'IntermediateDirectory': '$(OutDir)\\obj\\$(ProjectName)',
           'CharacterSet': '1',
         },
       }],

If we don't want to float a patch, we should be able to override it from common.gypi like this:

diff --git a/common.gypi b/common.gypi
index d87205e..7fd9efc 100644
--- a/common.gypi
+++ b/common.gypi
@@ -148,6 +148,10 @@
             }
           }]
         ],
+        'msvs_configuration_attributes': {
+          'IntermediateDirectory': '$(ConfigurationName)\\obj\\$(ProjectName)',
+          'OutputDirectory': '$(SolutionDir)$(ConfigurationName)',
+        },
         'msvs_settings': {
           'VCCLCompilerTool': {
             'Optimization': 3, # /Ox, full optimization

(Caveat emptor: needs to be duplicated in the Debug configuration.)

@bnoordhuis thanks for getting around to it sooner than me. I did a quick test on a windows box with that patch and it seems to work. /cc @ak239: can you think of a better upstream fix?

@bnoordhuis I confirm it works on my computer too. What prevents us from upstreaming this fix?

Are third_party being rolled as expected? https://github.com/v8/v8/blob/5.7-lkgr/third_party/inspector_protocol/lib/Values_h.template was updated 4 months ago and looks like this CL still has an old version.

Sorry, I've mistaken 5.6 and 5.7.