As brought up in nodejs/v8#2 I'm quite skeptical this is a good idea until we get better hooks for native promises. (Which seemed to be the plan to get in before node version 8, where this was originally supposed to land.)

CI run to validate across platforms: https://ci.nodejs.org/job/node-test-commit-v8-linux/421/

As brought up in nodejs/v8#2 I'm quite skeptical this is a good idea until we get better hooks for native promises.

That's a pretty cryptic comment on its own. I think the missing context is that 5.5 ships async/await without a flag?

Looks like CI failures across the board.

Afaik smartos14 support is dropped for 5.5

Updated.

There are some new utf-8 fixes (1, 2) that make test/parallel/test-string-decoder fail. I'm sure that someone already mentioned it but I can't find the related issue.

Example failure:

test('utf-8', Buffer.from('F0B841', 'hex'), '\ufffd\ufffdA');
// AssertionError: Expected "\ufffd\ufffd\u41", but got "\ufffd\u41"

If I change the expected value, the error is inverted:

test('utf-8', Buffer.from('F0B841', 'hex'), '\ufffdA');
// AssertionError: Expected "\ufffd\u41", but got "\ufffd\ufffd\u41"

@targos see discussion here: v8@af842a7#commitcomment-19855022

I'm turning the PR into a clean semver-major that can land on master. I'll then open another one to backport to v7.x.

This is still in progress because of v8@af842a7#commitcomment-19855022

@nodejs/platform-smartos What are we going to do with SmartOS 14? The CI cannot be green because of the incompatibility with this platform.

@targos as far as I know, it is to be dropped for 55 and forward. I can look at skipping testing against smartos14 for a specific node version; for instance 7.3?

@targos FWIW, what @jbergstroem mentioned:

as far as I know, it is to be dropped for 55 and forward.

sounds good to me.

P.S: sorry for the delay, I was on vacation until today.

I think it would be good to get 5.5. into master, because it gives us more time to test it with Node. Also, there are some API changes in 5.5 that are needed to address open issues.

5.7 was released this week, 5.8 should be out in time to be included in LTS 8.

Actually 5.7 was branched this week, not released. Also the timeline for 5.8 is close enough for it to be possible to be included in LTS 8, but there is open discussion on whether LTS 8 should include it: see #10117 (comment), #10970 and the discussion from the last Diagnostic WG meeting.

Currently the landing of V8 5.5 onto master seems to be blocked by this build issue: nodejs/build#595

CI run after change to job to not run on smartos14 if version is 8 or higher: https://ci.nodejs.org/job/node-test-pull-request/6052/

The only real CI failure is the clang ICE here, I assume that is expected?

New CI run, hopefully without infrastructure-related failures: https://ci.nodejs.org/job/node-test-commit/7490/

@addaleax correct. We'll just skip on that platform for now.

CI run one more time: https://ci.nodejs.org/job/node-test-pull-request/6073/

Landed in a67a04d...24ef1e6. Thanks everyone!

@targos Congratulations and thanks for hard work :) So does it lands on 7.x semver-minor updates? And what is your ETA?
Thanks again :)
Update: It seems back-port is on progress here #11029 :))

Is this means we can use async/await safely?

@aniddan In nightly builds, yes. In Node 7.x not yet, be V8 5.5 wasn't backported yet (#11029)

Will it be included in version 8 without flags?
Very well done @targos.

@leodutra It is already in master branch, thus in Node.js 8

@targos https://github.com/nodejs/node/blob/master/BUILDING.md#unix still mentions Clang 3.4 as the required version. Do you know what the new required version is?

@joaocgreis I don't know what is the actual required version but since we dropped the workaround from #8343 it must be at least 3.4.2.