FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: cover thrown errors from exec() kill by cjihrig · Pull Request #11038 · nodejs/node · GitHub

/ node Public

test: cover thrown errors from exec() kill - #11038

Closed
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:coverage
ConversationCommits (1)ChecksFiles changed
Closed

test: cover thrown errors from exec() kill#11038
cjihrig wants to merge 1 commit into
nodejs:masterfrom
cjihrig:coverage

Conversation

cjihrig commented Jan 27, 2017

Copy link
Copy Markdown
Contributor

This commit adds code coverage for the scenario where exec() kills a child process, but the call to ChildProcess#kill() throws an exception.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Jan 27, 2017
lpinca reviewed Jan 27, 2017
View reviewed changes
Comment thread test/parallel/test-child-process-exec-kill-throws.js Outdated

lpinca Jan 27, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

s/path/patch/ ?

sam-github reviewed Jan 27, 2017
View reviewed changes
Comment thread test/parallel/test-child-process-exec-kill-throws.js Outdated

sam-github Jan 27, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

what if it throws because the child exited, wouldn't that be success?

cjihrig Jan 27, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'm not sure that I understand the question. Do you mean if Node decides to kill the child process, but in the interim it exits on its own? If exithandler() runs (via the close handler for example), then the error won't be reported because it contains a check to make sure it doesn't run twice.

FWIW, this is the code path being tested.

sam-github Jan 27, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

node could decided to kill the child, but between when it decided and the child is killed, the child can exit. It would be possible to special case

node/lib/child_process.js

Line 265 in 3268863

ex = e;
for ESRCH, and not call exit handler in that case, because it just means that node has not yet epolled the exit status, but it will in the next tick or so. But the event ordering of the timeout vs the process exit is indeterminate by nature, so its no big deal.

test: cover thrown errors from exec() kill
a514264 
This commit adds code coverage for the scenario where exec()
kills a child process, but the call to ChildProcess#kill()
throws an exception.

PR-URL: nodejs#11038
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

cjihrig commented Jan 30, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/6104/

EDIT: CI: https://ci.nodejs.org/job/node-test-pull-request/6342/

cjihrig mentioned this pull request Feb 10, 2017
Closed
3 tasks

cjihrig commented Feb 10, 2017

Copy link
Copy Markdown
Contributor Author

CI was 💚

jasnell commented Feb 17, 2017

Copy link
Copy Markdown
Member

It's been sitting for a bit, new CI: https://ci.nodejs.org/job/node-test-pull-request/6461/

fhinkel commented Mar 26, 2017

Copy link
Copy Markdown
Contributor

Landed in 9ac363b

fhinkel closed this Mar 26, 2017
fhinkel pushed a commit that referenced this pull request Mar 26, 2017
test: cover thrown errors from exec() kill
9ac363b 
This commit adds code coverage for the scenario where exec()
kills a child process, but the call to ChildProcess#kill()
throws an exception.

PR-URL: #11038
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
cjihrig deleted the coverage branch March 26, 2017 12:04

cjihrig commented Mar 26, 2017

Copy link
Copy Markdown
Contributor Author

We'll have to watch this test carefully. I hadn't landed this yet because it appeared to be flakey on Windows.

gibfahn commented Mar 26, 2017

Copy link
Copy Markdown
Member

Stress test on Windows: https://ci.nodejs.org/job/node-stress-single-test/1141/

gibfahn commented Mar 26, 2017

Copy link
Copy Markdown
Member

Stress test results: OK: 5844 NOT OK: 4155 TOTAL: 9999. This is looping the test sequentially.

@cjihrig should we revert? Mark flaky on windows?

gibfahn mentioned this pull request Mar 26, 2017
Closed
2 tasks

cjihrig commented Mar 26, 2017

Copy link
Copy Markdown
Contributor Author

I'd be OK with either. I think there might be a genuine bug with kill() on Windows, so maybe marking it as flaky will keep it on the radar.

gibfahn mentioned this pull request Mar 26, 2017
Closed
gibfahn mentioned this pull request Mar 26, 2017
Merged
2 tasks
gibfahn added a commit to gibfahn/node that referenced this pull request Mar 27, 2017
test: mark child-process-exec-kill-throws flaky
66e7dc5 
PR-URL: nodejs#12054
Ref: nodejs#12053
Ref: nodejs#11038
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
test: cover thrown errors from exec() kill
41284fb 
This commit adds code coverage for the scenario where exec()
kills a child process, but the call to ChildProcess#kill()
throws an exception.

PR-URL: #11038
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
test: mark child-process-exec-kill-throws flaky
8b2b93f 
PR-URL: #12054
Ref: #12053
Ref: #11038
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins mentioned this pull request Mar 28, 2017
Merged
gibfahn mentioned this pull request Mar 29, 2017
Closed
2 tasks
italoacasas mentioned this pull request Apr 10, 2017
Merged
2 tasks
MylesBorins added the baking-for-lts PRs that need to wait before landing in a LTS release. label May 15, 2017
MylesBorins removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Aug 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca left review comments
jasnell jasnell approved these changes
+2 more reviewers
sam-github sam-github approved these changes
fhinkel fhinkel approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL