FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: mark child-process-exec-kill-throws flaky by gibfahn · Pull Request #12054 · nodejs/node · GitHub

/ node Public

test: mark child-process-exec-kill-throws flaky - #12054

Merged
gibfahn merged 1 commit into
nodejs:masterfrom
gibfahn:flaky-exec-kill-win
Mar 27, 2017
ConversationCommits (1)ChecksFiles changed
Merged

test: mark child-process-exec-kill-throws flaky#12054
gibfahn merged 1 commit into
nodejs:masterfrom
gibfahn:flaky-exec-kill-win

Conversation

gibfahn commented Mar 26, 2017

Copy link
Copy Markdown
Member

Refs: #12053
Refs: #11038

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines][]
Affected core subsystem(s)

test

cc/ @cjihrig @nodejs/testing @nodejs/platform-windows

gibfahn added child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform. labels Mar 26, 2017
nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 26, 2017
gibfahn mentioned this pull request Mar 26, 2017
Closed

gibfahn commented Mar 26, 2017 •
edited
Loading

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-commit/8698/

EDIT: Windows seems to be green.

aqrln mentioned this pull request Mar 27, 2017
Closed
2 tasks

jasnell commented Mar 27, 2017

Copy link
Copy Markdown
Member

I'd prefer to get this landed sooner than later so we can unbreak CI

gibfahn self-assigned this Mar 27, 2017

gibfahn commented Mar 27, 2017

Copy link
Copy Markdown
Member Author

Landing...

gibfahn force-pushed the flaky-exec-kill-win branch from 9a475b9 to 3c9d6ff Compare March 27, 2017 17:44
test: mark child-process-exec-kill-throws flaky
66e7dc5 
PR-URL: nodejs#12054
Ref: nodejs#12053
Ref: nodejs#11038
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
gibfahn force-pushed the flaky-exec-kill-win branch from 3c9d6ff to 66e7dc5 Compare March 27, 2017 17:45
gibfahn merged commit 66e7dc5 into nodejs:master Mar 27, 2017
gibfahn deleted the flaky-exec-kill-win branch March 27, 2017 17:47
MylesBorins pushed a commit that referenced this pull request Mar 28, 2017
test: mark child-process-exec-kill-throws flaky
8b2b93f 
PR-URL: #12054
Ref: #12053
Ref: #11038
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins mentioned this pull request Mar 28, 2017
Merged
italoacasas mentioned this pull request Apr 10, 2017
Merged
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
santigimeno santigimeno approved these changes
cjihrig cjihrig approved these changes
richardlau richardlau approved these changes

Assignees

gibfahn

Labels

child_process Issues and PRs related to the child_process subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL