CI: https://ci.nodejs.org/job/node-test-pull-request/6947/

@nodejs/platform-windows

cc @nodejs/testing

Is cat included by default on windows machines? I know you get it through Git Bash, which we require, but I didn't think it came with CMD by default.

@gibfahn I don't think cat is included. I just thought the build requirements was a safe condition for it.

@gibfahn no, not by default. We already require Git Bash, tests already fail if the Unix tools are not installed, so I think it's better to make it consistent.

@vsemozhetbyt you have the same issue in Refs: and Fixes:, you can leave only the Fixes: line.

@vsemozhetbyt Yep, that was the context I hadn't seen.

I think it's fine to assume the developer will have cat.exe on the system due to it being included in Git Bash, the only issue is that the developer might not have the path to the Git command tools in their CMD path. I guess the answer is to document that you will need to add C:\Program Files\Git\usr\bin to your system path if it's not there already.

@gibfahn It seems something like that is already present in the doc:

Basic Unix tools required for some tests, Git for Windows includes Git Bash and tools which can be included in the global PATH.

the only issue is that the developer might not have the path to the Git command tools in their CMD path

That's the same with other tests too.

Landed in 2dff3a2

This is causing failures for OSX testing on v6.x. did not cherry-pick. LMK if it should land

post-mortem

1. I pro-uniformity (i.e. anti-disparity). (so I'm not suggesting we use the built in Windows type which is the equivalent to cat)
2. I don't have cat in my Path, also adding ...\Git\usr\bin or any other unix tools folder, as it has some non-trivial side effects.
3. I have no problem with special setup for building/testing node.

bottom-line

But in case changes like this are added I would like to ask for a quick failing sanity check to be added to run early to remind us if something in the environment is missing
/cc @nodejs/platform-windows

Such a test will also be a defacto documentation of what the following process is dependent on.

also adding ...\Git\usr\bin or any other unix tools folder, as it has some non-trivial side effects.

Out of interest, what side effects are those?

I would like to ask for a quick failing sanity check to be added to run early to remind us if something in the environment is missing

A test that just runs through all the tools test.py expects makes sense to me, and not just for Windows.

The post-morgen tag is for post mortem analysis related issues like core dump problems.

Also, not sure why something not landing cleanly on an old version requires post-mortem analysis?

The post-morgen tag is for post mortem analysis related issues like core dump problems.

Sorry. it's not documented (or I couldn't find where).

Also, not sure why something not landing cleanly on an old version requires post-mortem analysis?

Since this has already landed, I could only consider this a post-mortem for it creating a regression on Windows. After my #12493 I didn't want to tag in "regression" since it's not such a big deal.

also adding ...\Git\usr\bin or any other unix tools folder, as it has some non-trivial side effects.

Out of interest, what side effects are those?

For some reason if sh.exe is in the path, make can't run properly. Also it overrides find and if you don't order your %Path% correctly, it overrides some ported tools, like curl or wget.

@gibfahn Ref: the Git4Windows installer https://github.com/git-for-windows/build-extra/blob/master/installer/install.iss#L863

FWIW the contributing guide mentions that the building guide should be read when running tests and the building guide does mention in the Windows section that basic unix tools are required for some tests and that they can be installed via Git for Windows.

@mscdex aware, agree, but supporting docs with automation make for a time saver :-D