FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix a problem that the test fails at the windows7 command prompt by briete · Pull Request #22102 · nodejs/node · GitHub

/ node Public

test: fix a problem that the test fails at the windows7 command prompt - #22102

Closed
briete wants to merge 1 commit into
nodejs:masterfrom
briete:test-resolve-ENOENT
ConversationCommits (1)ChecksFiles changed
Closed

test: fix a problem that the test fails at the windows7 command prompt#22102
briete wants to merge 1 commit into
nodejs:masterfrom
briete:test-resolve-ENOENT

Conversation

briete commented Aug 3, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

When testing with 'cmd.exe' of Windows 7,
'spawn cat ENOENT' error has occurred.
Since the standard 'cmd.exe' has no 'cat' command,
Instead will use the 'type' command

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

test: fix a problem that the test fails at the windows7 command prompt
b479f5a 
When testing with 'cmd.exe' of Windows 7,
'spawn cat ENOENT' error has occurred.
Since the standard 'cmd.exe' has no 'cat' command,
Instead will use the 'type' command
nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 3, 2018
hiroppy added http Issues or PRs related to the http subsystem. wsl Issues and PRs related to the Windows Subsystem for Linux. windows Issues and PRs related to the Windows platform. and removed wsl Issues and PRs related to the Windows Subsystem for Linux. labels Aug 3, 2018

richardlau commented Aug 3, 2018

Copy link
Copy Markdown
Member

cc @nodejs/platform-windows

We used to have common.spawnCat which had Windows specific logic to avoid cat, but this was removed in #11953.

This is not the only test to use cat, e.g. test/parallel/test-child-process-stdio.js. We do require basic Unix tools on Windows for tests, https://github.com/nodejs/node/blob/master/BUILDING.md#windows-1:

  • Basic Unix tools required for some tests, Git for Windows includes Git Bash and tools which can be included in the global PATH.

briete commented Aug 5, 2018

Copy link
Copy Markdown
Contributor Author

@richardlau
Thank you for review.
To build and test Node.js on Windows, use UNIX tools.

BridgeAR commented Sep 5, 2018

Copy link
Copy Markdown
Member

If I understand the comments correct, this should be closed. @briete thanks for your contribution!

If this is closed by mistake, please reopen or leave a comment to ask that this should be reopened.

BridgeAR closed this Sep 5, 2018

briete commented Sep 7, 2018

Copy link
Copy Markdown
Contributor Author

@BridgeAR I'm sorry. understood.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes

Assignees

No one assigned

Labels

http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL