test: changed equality comparison to identity operator - #12405
Closed
fcampinho wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
addaleax
approved these changes
Apr 13, 2017
vsemozhetbyt
approved these changes
Apr 13, 2017
Copy link
Copy Markdown
Contributor
|
Thank you! |
Sorry, something went wrong.
Trott
approved these changes
Apr 13, 2017
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM if CI is green
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Minor nit for whoever lands this (or if @fcampinho wants to fix it up and force push, that's cool too): First word of the commit message should be an imperative verb, so changed should be change. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Minor nit part 2: The first line should be 50 chars max so maybe test: change == to === in crypto test or something like that |
Sorry, something went wrong.
benjamingr
approved these changes
Apr 13, 2017
jasnell
approved these changes
Apr 13, 2017
Changed the equality comparison from == to identity operator ===
Copy link
Copy Markdown
Contributor
Author
|
Sorry @Trott , first commit, I executed a git push --force |
Sorry, something went wrong.
cjihrig
approved these changes
Apr 14, 2017
aqrln
approved these changes
Apr 15, 2017
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Apr 16, 2017
Changed the equality comparison from == to identity operator === PR-URL: nodejs#12405 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Copy link
Copy Markdown
Member
|
Thanks for the contribution! 🎉 |
Sorry, something went wrong.
3 tasks
4 tasks
4 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Oct 16, 2017
Changed the equality comparison from == to identity operator === PR-URL: #12405 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Oct 25, 2017
Changed the equality comparison from == to identity operator === PR-URL: #12405 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test: changed equality comparison to identity operator
Changed the equality comparison from == to identity operator ===