| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
|
@gibfahn Do you want a separate PR, separate commit, or can I just adopt and force-push that one-character fix? |
Sorry, something went wrong.
Sorry, something went wrong.
|
same PR, you can amend or cherry-pick, as you wish. I'd probably amend. |
Sorry, something went wrong.
|
Separate commit (cherry-pick it onto your backport-11705-to-v6.x branch). Please don't amend, that makes working out what has been backported harder. |
Sorry, something went wrong.
There was a problem hiding this comment.
This LGTM, although I'd appreciate a quick look from @nodejs/crypto
Sorry, something went wrong.
|
LGTM, this basically lands clean, the conflicts are tiny, and just due to sign/verify being given names in master, and being anonymous in v6.x. |
Sorry, something went wrong.
|
This would have landed clean if #8993 had been landed, I'll comment there. |
Sorry, something went wrong.
There was a problem hiding this comment.
key: {string} - PEM encoded public key (required)
Sorry, something went wrong.
|
@gibfahn Status on this? Should I rebase? |
Sorry, something went wrong.
|
See #11705 (comment), this will have to wait till we review semver-minor backports before 6.12.0. I wouldn't bother rebasing yet. You can subscribe to nodejs/Release#228 if you want to know when LTS will decide on backporting. |
Sorry, something went wrong.
|
We've agreed to land this. |
Sorry, something went wrong.
|
@MylesBorins #8993 will be needed as well to land clean |
Sorry, something went wrong.
|
@tniessen do you want to take another pass at this now that #8993 (comment) has landed its dependent PR? If not, ping me, and I will. |
Sorry, something went wrong.
PR-URL: nodejs#14107 Fixes: nodejs#14105 Reviewed-By: Refael Ackermann <refack@gmail.com>
Use try/catch to instead of threw. PR-URL: nodejs#10534 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Simplify the BSD list by defining OPENSSL_BSD if using a matching BSD platform. Add NetBSD to the list and update documentation. PR-URL: nodejs#14313 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
As an example, `curl https://nodejs.org/dist/v8.4.0/SHASUM256.txt` will return a 404 right now. PR-URL: nodejs#15101 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Create one file for testing each function of the path module. Keep general error tests and tests for constant properties in test-path.js. PR-URL: nodejs#15093 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Adds support for the PSS padding scheme. Until now, the sign/verify functions used the old EVP_Sign*/EVP_Verify* OpenSSL API, making it impossible to change the padding scheme. Fixed by first computing the message digest and then signing/verifying with a custom EVP_PKEY_CTX, allowing us to specify options such as the padding scheme and the PSS salt length. Fixes: nodejs#1127 PR-URL: nodejs#11705 Reviewed-By: Shigeki Ohtsu <ohtsu@ohtsu.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Hope I did not miss anything. CI: https://ci.nodejs.org/job/node-test-pull-request/10172/ |
Sorry, something went wrong.
| Back | FazBrowse Home | New Git URL |
Backport of #11705 to v6.x @nodejs/lts
Checklist
Affected core subsystem(s)
crypto