FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: avoid /docs/api and /docs/doc/api upload by rvagg · Pull Request #12957 · nodejs/node · GitHub

/ node Public

build: avoid /docs/api and /docs/doc/api upload - #12957

Closed
rvagg wants to merge 1 commit into
nodejs:masterfrom
rvagg:docs-rsync
ConversationCommits (1)ChecksFiles changed
Closed

build: avoid /docs/api and /docs/doc/api upload#12957
rvagg wants to merge 1 commit into
nodejs:masterfrom
rvagg:docs-rsync

Conversation

rvagg commented May 11, 2017

Copy link
Copy Markdown
Member

Fixes problem of having /docs/api and /docs/doc/api directories in our distributions, caused by a double (or more) build on CI server prior to promotion as reported and discussed in #12833.

scp -pr out/doc/ server:.../docs/ first sees a missing /docs/ directory so puts the out/doc/ contents into /docs/, second pass it sees an existing directory so makes a new /docs/doc/ directory for the upload.

This fix ensures the directory exists initially and then does an scp of the contents of the out/doc/ directory rather than the directory itself.

Needs to be backported to all active release lines once confirmed working.

nodejs-github-bot added the build Issues and PRs related to build files or the CI. label May 11, 2017

rvagg commented May 11, 2017

Copy link
Copy Markdown
Member Author

/cc @nodejs/build

note on the branch name .. that I forgot to change .. initial solution switched to rsync with --delete which is much nicer but I decided to go with a more minimal change in the end.

This was referenced May 11, 2017
Closed
Closed

rvagg commented May 11, 2017

Copy link
Copy Markdown
Member Author

tested this @ https://nodejs.org/download/test/v8.0.0-test201705113064a21223/docs/ and it's fine, it's not a perfect replication of a release build as the promotion is automatic so I had to un-promote the docs before running again, also I had to add in the patch in #12958 to get it to build, but I believe it's close enough to realistic.

joaocgreis approved these changes May 11, 2017
View reviewed changes

joaocgreis left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

mhdawson approved these changes May 12, 2017
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

joaocgreis commented May 23, 2017

Copy link
Copy Markdown
Member

I can land tomorrow if there's no objection. @rvagg let me know if you want to land this yourself.

addaleax commented May 23, 2017

Copy link
Copy Markdown
Member

Landed in 7a1dc1f

addaleax closed this May 23, 2017
addaleax pushed a commit that referenced this pull request May 23, 2017
build: avoid /docs/api and /docs/doc/api upload
7a1dc1f 
Fixes: #12833
PR-URL: #12957
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
jasnell pushed a commit that referenced this pull request May 24, 2017
build: avoid /docs/api and /docs/doc/api upload
de012d3 
Fixes: #12833
PR-URL: #12957
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
jasnell pushed a commit that referenced this pull request May 28, 2017
build: avoid /docs/api and /docs/doc/api upload
77dfa2b 
Fixes: #12833
PR-URL: #12957
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
jasnell mentioned this pull request May 28, 2017
Closed
gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
MylesBorins pushed a commit that referenced this pull request Jul 17, 2017
build: avoid /docs/api and /docs/doc/api upload
40fb0da 
Fixes: #12833
PR-URL: #12957
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
MylesBorins pushed a commit that referenced this pull request Jul 17, 2017
build: avoid /docs/api and /docs/doc/api upload
85829a6 
Fixes: #12833
PR-URL: #12957
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
MylesBorins mentioned this pull request Jul 18, 2017
Merged
MylesBorins mentioned this pull request Sep 20, 2017
Closed
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
build: avoid /docs/api and /docs/doc/api upload
e2b6fdf 
Fixes: #12833
PR-URL: #12957
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <mhdawson@ibm.com>
MylesBorins mentioned this pull request Oct 25, 2017
Merged
rvagg added a commit to rvagg/io.js that referenced this pull request Nov 23, 2018
build: only check REPLACEME & DEP...X for releases
6759a2e 
Ref: nodejs#24551
Ref: nodejs#12958
Ref: nodejs#12957
Ref: nodejs#8325
rvagg mentioned this pull request Nov 23, 2018
Closed
rvagg added a commit that referenced this pull request Nov 28, 2018
build: only check REPLACEME & DEP...X for releases
89e8fc4 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
build: only check REPLACEME & DEP...X for releases
955819e 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
build: only check REPLACEME & DEP...X for releases
eaec87b 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
build: only check REPLACEME & DEP...X for releases
a8402fe 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg added a commit that referenced this pull request Nov 28, 2018
build: only check REPLACEME & DEP...X for releases
25103af 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
build: only check REPLACEME & DEP...X for releases
d9e10fb 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Dec 3, 2018
build: only check REPLACEME & DEP...X for releases
aa88483 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
build: only check REPLACEME & DEP...X for releases
97d8bc8 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
build: only check REPLACEME & DEP...X for releases
51272a9 
PR-URL: nodejs#24575
Refs: nodejs#24551
Refs: nodejs#12958
Refs: nodejs#12957
Refs: nodejs#8325
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg added a commit that referenced this pull request Feb 28, 2019
build: only check REPLACEME & DEP...X for releases
3e4a0ff 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
BethGriggs pushed a commit that referenced this pull request Mar 7, 2019
build: only check REPLACEME & DEP...X for releases
9ba5fd6 
PR-URL: #24575
Refs: #24551
Refs: #12958
Refs: #12957
Refs: #8325
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers
joaocgreis joaocgreis approved these changes
mhdawson mhdawson approved these changes
gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL