build: only check REPLACEME & DEP...X for releases - #24575
Closed
rvagg wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
@rvagg build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1682/pipeline |
Sorry, something went wrong.
refack
approved these changes
Nov 23, 2018
refack
reviewed
Nov 23, 2018
Comment thread
Makefile
danbev
approved these changes
Nov 23, 2018
richardlau
approved these changes
Nov 23, 2018
Copy link
Copy Markdown
Member
Author
|
I've removed this from all over iojs+release: if [[ "X${disttype}" != "Xrelease" ]]; then
perl -pi -e "s/: release-only/:/g" Makefile
fiSo @nodejs/build & @nodejs/releasers need to keep an eye out for funny behaviour, it's been in place for a long time. I've kicked off a test build and a rerun of the last nightly build, just to test. Tomorrow I might try a re-do of one of today's releases and then clean it up from staging. |
Sorry, something went wrong.
rvagg
added a commit
that referenced
this pull request
Nov 28, 2018
rvagg
added a commit
that referenced
this pull request
Nov 28, 2018
rvagg
added a commit
that referenced
this pull request
Nov 28, 2018
rvagg
added a commit
that referenced
this pull request
Nov 28, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Nov 29, 2018
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Dec 3, 2018
Merged
This was referenced Dec 7, 2018
This was referenced Dec 18, 2018
MylesBorins
pushed a commit
that referenced
this pull request
Dec 26, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24575 Refs: nodejs#24551 Refs: nodejs#12958 Refs: nodejs#12957 Refs: nodejs#8325 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
rvagg
added a commit
that referenced
this pull request
Feb 28, 2019
BethGriggs
pushed a commit
that referenced
this pull request
Mar 7, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A rehash of #12958.
Summary: the introduction of the checks for REPLACEME and later DEP...X in the release-only Makefile target screwed up "test" and "rc" builds. There are exclusions for "nightly" and "next-nightly" because those are automatic and IIRC we noticed those builds stopped working shortly after the REPLACEME check was instituted. However, "test" and "rc" builds are manual and don't work with this check. Now we also have "v8-canary" in the mix too. These extras make use of the "custom" DISTTYPE.
This got held up because there was disagreement about how exclusive to be. The original change proposed in #8325 was similar to this one but it was then made exclusive by switching to the "nightly" and "next-nightly" builds.
For the last ~18 months we've had this in ci-release:
i.e. overriding the release-only target in Makefile for everything but "release" builds.
This PR aims to put that logic into Makefile so we can remove that check.
Ref: #24551
Ref: #12958
Ref: #12957
Ref: #8325