cluster: disconnect event was not emitted correctly - #1386
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Instead of doing this, can you check out test/parallel/test-cluster-worker-death.js, and do something similar.
EDIT: Upon further review, that approach might not work. @bnoordhuis any better ideas on how to trigger an assertion in the parent process after a disconnect in the child?
Sorry, something went wrong.
There was a problem hiding this comment.
Instead of creating files in __dirname, can you use common.tmpDir.
Sorry, something went wrong.
There was a problem hiding this comment.
Please add a space between ) and {
Sorry, something went wrong.
|
One style nit. Can you address it and squash the commits. Then, I'll run it through the CI. |
Sorry, something went wrong.
Fix for nodejs#1304 Inside of a worker, disconnect event was not emitted on cluster.worker
Sorry, something went wrong.
|
CI looks good. I'll merge this in the coming days, assuming there is no more activity. |
Sorry, something went wrong.
|
@brendanashworth do I need to rewrite my PR to master branch? |
Sorry, something went wrong.
|
No, it'll be merged manually into master anyways. |
Sorry, something went wrong.
PR-URL: nodejs#1679 Notable Changes: * win,node-gyp: the delay-load hook for windows addons has now been correctly enabled by default, it had wrongly defaulted to off in the release version of 2.0.0 (Bert Belder) nodejs#1433 * os: tmpdir()'s trailing slash stripping has been refined to fix an issue when the temp directory is at '/'. Also considers which slash is used by the operating system. (cjihrig) nodejs#1673 * tls: default ciphers have been updated to use gcm and aes128 (Mike MacCana) nodejs#1660 * build: v8 snapshots have been re-enabled by default as suggested by the v8 team, since prior security issues have been resolved. This should give some perf improvements to both startup and vm context creation. (Trevor Norris) nodejs#1663 * src: fixed preload modules not working when other flags were used before --require (Yosuke Furukawa) nodejs#1694 * dgram: fixed send()'s callback not being asynchronous (Yosuke Furukawa) nodejs#1313 * readline: emitKeys now keeps buffering data until it has enough to parse. This fixes an issue with parsing split escapes. (Alex Kocharin) * cluster: works now properly emit 'disconnect' to cluser.worker (Oleg Elifantiev) nodejs#1386 events: uncaught errors now provide some context (Evan Lucas) nodejs#1654
Inside of a worker, disconnect event was not emitted on cluster.worker Fixes: nodejs#1304 PR-URL: nodejs#1386 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fix for #1304
Inside of a worker, disconnect event was not emitted on cluster.worker