| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
There was a problem hiding this comment.
preloadModules (plural) may be better :)
Sorry, something went wrong.
There was a problem hiding this comment.
👍
Sorry, something went wrong.
|
LGTM. |
Sorry, something went wrong.
|
PTAL. @rvagg @chrisdickinson @trevnorris |
Sorry, something went wrong.
|
LGTM |
Sorry, something went wrong.
Sorry, something went wrong.
|
Errors are either jenkins or recently fixed, other than But it seems unrelated. |
Sorry, something went wrong.
|
Thanks, landed in 0a461e5 for 2.0.2 |
Sorry, something went wrong.
PR-URL: nodejs#1679 Notable Changes: * win,node-gyp: the delay-load hook for windows addons has now been correctly enabled by default, it had wrongly defaulted to off in the release version of 2.0.0 (Bert Belder) nodejs#1433 * os: tmpdir()'s trailing slash stripping has been refined to fix an issue when the temp directory is at '/'. Also considers which slash is used by the operating system. (cjihrig) nodejs#1673 * tls: default ciphers have been updated to use gcm and aes128 (Mike MacCana) nodejs#1660 * build: v8 snapshots have been re-enabled by default as suggested by the v8 team, since prior security issues have been resolved. This should give some perf improvements to both startup and vm context creation. (Trevor Norris) nodejs#1663 * src: fixed preload modules not working when other flags were used before --require (Yosuke Furukawa) nodejs#1694 * dgram: fixed send()'s callback not being asynchronous (Yosuke Furukawa) nodejs#1313 * readline: emitKeys now keeps buffering data until it has enough to parse. This fixes an issue with parsing split escapes. (Alex Kocharin) * cluster: works now properly emit 'disconnect' to cluser.worker (Oleg Elifantiev) nodejs#1386 events: uncaught errors now provide some context (Evan Lucas) nodejs#1654
Fixes: nodejs#1691 PR-URL: nodejs#1694 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Fixes: nodejs/node#1691 PR-URL: nodejs/node#1694 Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
| Back | FazBrowse Home | New Git URL |
related: #881
related: #1691
I investigate the issue.
it should load modules after path.resolve(process.argv[1]);
Reviewer: @ofrobots