FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Fix broken openssl links by kasicka · Pull Request #15182 · nodejs/node · GitHub

/ node Public

Fix broken openssl links - #15182

Closed
kasicka wants to merge 2 commits into
nodejs:v4.x-stagingfrom
kasicka:fix-spkac-link
Closed

Fix broken openssl links#15182
kasicka wants to merge 2 commits into
nodejs:v4.x-stagingfrom
kasicka:fix-spkac-link

Conversation

kasicka commented Sep 4, 2017

Copy link
Copy Markdown

Found dead link in doc, seems fixed in later releases.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

nodejs-github-bot added crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations. v4.x labels Sep 4, 2017

targos commented Sep 4, 2017

Copy link
Copy Markdown
Member

There are probably other dead links. It was fixed in #9338 which was not backported to v4.x.
/cc @nodejs/lts

kasicka changed the title Fix dead link to SPKAC Fix broken openssl links Sep 4, 2017

kasicka commented Sep 4, 2017

Copy link
Copy Markdown
Author

Fixed other links I found.

silverwind left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Not a fan of versions in links, but I guess we can't really do anything about it.

MylesBorins pushed a commit that referenced this pull request Sep 19, 2017
PR-URL: #15182
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

Copy link
Copy Markdown
Contributor

landed in fc6145f

MylesBorins mentioned this pull request Sep 20, 2017
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
PR-URL: #15182
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
MylesBorins mentioned this pull request Oct 25, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

crypto Issues and PRs related to the crypto subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants


Back | FazBrowse Home | New Git URL