doc: updating OpenSSL links - #9338
Closed
kobelb wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
kobelb
force-pushed
the
docs-openssl-links
branch
from
4240ff2 to
ba060d8
Compare
October 28, 2016 13:29
jasnell
approved these changes
Oct 28, 2016
Copy link
Copy Markdown
Contributor
|
LGTM The links will need to be updated when OpenSSL is updated in deps/. I can't see any docs for how the OpenSSL update is made, I guess @nodejs/crypto folks will have to remember. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I added this info to https://github.com/nodejs/node/wiki/OpenSSL-upgrade-process#performing-the-upgrade. |
Sorry, something went wrong.
silverwind
approved these changes
Nov 1, 2016
silverwind
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
silverwind
pushed a commit
that referenced
this pull request
Nov 1, 2016
PR-URL: #9338 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
evanlucas
pushed a commit
that referenced
this pull request
Nov 3, 2016
PR-URL: #9338 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 22, 2016
PR-URL: #9338 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc
Description of change
Update OpenSSL links in docs to reference version 1.0.2.
The following pull-request moved the OpenSSL docs breaking a lot of links in the node docs: openssl/openssl#1758
There are now separate pages for different versions and master. For example https://www.openssl.org/docs/apps/ca.html is no longer accessible, but it's available at
https://www.openssl.org/docs/man1.0.2/apps/ca.html and https://www.openssl.org/docs/manmaster/man1/ca.html
Resolves #9327