FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fs.write() if 3rd argument is a callback, not offset by PatrickHeneise · Pull Request #16822 · nodejs/node · GitHub

/ node Public

test: fs.write() if 3rd argument is a callback, not offset - #16822

Closed
PatrickHeneise wants to merge 4 commits into
nodejs:masterfrom
PatrickHeneise:cov-fs
ConversationCommits (4)ChecksFiles changed
Closed

test: fs.write() if 3rd argument is a callback, not offset#16822
PatrickHeneise wants to merge 4 commits into
nodejs:masterfrom
PatrickHeneise:cov-fs

Conversation

PatrickHeneise commented Nov 6, 2017

Copy link
Copy Markdown
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 6, 2017
mscdex reviewed Nov 6, 2017
View reviewed changes
Comment thread test/parallel/test-fs-write.js Outdated

fs.open(fn, 'w', 0o644, common.mustCall(function(err, fd) {
assert.ifError(err);
console.log('open done');

mscdex Nov 6, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think these console statements can be left out.

PatrickHeneise Nov 6, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

done, thanks!

mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Nov 6, 2017
gireeshpunathil added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Nov 6, 2017
cjihrig approved these changes Nov 6, 2017
View reviewed changes
Comment thread test/parallel/test-fs-write.js
fs.open(fn, 'w', 0o644, common.mustCall(function(err, fd) {
assert.ifError(err);
const done = common.mustCall(function(err, written) {
assert.strictEqual(Buffer.byteLength(expected), written);

cjihrig Nov 6, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Maybe add an assert.ifError(err); here.

PatrickHeneise Nov 7, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks

PatrickHeneise mentioned this pull request Nov 15, 2017
Closed
3 tasks

PatrickHeneise commented Nov 15, 2017

Copy link
Copy Markdown
Author

New PR without conflicts #17045

addaleax pushed a commit that referenced this pull request Nov 18, 2017
test: fs.write() if 3rd argument is a callback, not offset
8f8999c 
Easier way to resolve conflicts from #16822 and #16827.

PR-URL: #17045
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: fs.write() if 3rd argument is a callback, not offset
79ba863 
Easier way to resolve conflicts from #16822 and #16827.

PR-URL: #17045
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
test: fs.write() if 3rd argument is a callback, not offset
c01d934 
Easier way to resolve conflicts from #16822 and #16827.

PR-URL: #17045
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
test: fs.write() if 3rd argument is a callback, not offset
2f276c8 
Easier way to resolve conflicts from #16822 and #16827.

PR-URL: #17045
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
+1 more reviewer
mscdex mscdex left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL