FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fs.write() if 3rd argument is a callback, not offset by PatrickHeneise · Pull Request #17045 · nodejs/node · GitHub

/ node Public

test: fs.write() if 3rd argument is a callback, not offset - #17045

Closed
PatrickHeneise wants to merge 3 commits into
nodejs:masterfrom
PatrickHeneise:cov-fs-2
ConversationCommits (3)ChecksFiles changed
Closed

test: fs.write() if 3rd argument is a callback, not offset#17045
PatrickHeneise wants to merge 3 commits into
nodejs:masterfrom
PatrickHeneise:cov-fs-2

Conversation

PatrickHeneise commented Nov 15, 2017

Copy link
Copy Markdown

#16827 and #16822 resulted in some serious merge conflicts, so I decided to open a fresh PR for this with everything resolved.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

nodejs-github-bot added the test Issues and PRs related to the tests. label Nov 15, 2017
PatrickHeneise mentioned this pull request Nov 15, 2017
Closed
3 tasks
mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Nov 15, 2017
cjihrig reviewed Nov 16, 2017
View reviewed changes
Comment thread test/parallel/test-fs-write.js Outdated
fs.write(fd, expected, 0, 'utf8', done);
}));

fs.open(fn, 'w', 0o644, common.mustCall(function(err, fd) {

cjihrig Nov 16, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I'd use something other than fn to prevent any issues with the tests interacting with one another.

PatrickHeneise Nov 17, 2017

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Done, thanks.

jasnell reviewed Nov 16, 2017
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM with @cjihrig's comment addressed

addaleax commented Nov 18, 2017

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-commit/14132/

This should be ready.

addaleax added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 18, 2017

addaleax commented Nov 18, 2017

Copy link
Copy Markdown
Member

Landed in 8f8999c, thanks for the PR! ✨

addaleax closed this Nov 18, 2017
addaleax pushed a commit that referenced this pull request Nov 18, 2017
test: fs.write() if 3rd argument is a callback, not offset
8f8999c 
Easier way to resolve conflicts from #16822 and #16827.

PR-URL: #17045
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Trott removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Nov 18, 2017
PatrickHeneise deleted the cov-fs-2 branch November 18, 2017 21:52
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: fs.write() if 3rd argument is a callback, not offset
79ba863 
Easier way to resolve conflicts from #16822 and #16827.

PR-URL: #17045
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
test: fs.write() if 3rd argument is a callback, not offset
c01d934 
Easier way to resolve conflicts from #16822 and #16827.

PR-URL: #17045
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
test: fs.write() if 3rd argument is a callback, not offset
2f276c8 
Easier way to resolve conflicts from #16822 and #16827.

PR-URL: #17045
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn mentioned this pull request Dec 20, 2017
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell left review comments
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL