test: replace assert.throws with common.expectsError - #17494
Closed
mithunsasidharan wants to merge 1 commit into
Closed
test: replace assert.throws with common.expectsError#17494mithunsasidharan wants to merge 1 commit into
mithunsasidharan wants to merge 1 commit into
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
apapirovski
approved these changes
Dec 6, 2017
apapirovski
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM but commit message should ideally be adjusted to <= 50 chars.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@apapirovski : Thanks.. updated both PR and commit message. Thanks ! |
Sorry, something went wrong.
jasnell
approved these changes
Dec 6, 2017
cjihrig
approved these changes
Dec 6, 2017
BridgeAR
approved these changes
Dec 6, 2017
maclover7
approved these changes
Dec 7, 2017
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
lpinca
approved these changes
Dec 7, 2017
3 tasks
Copy link
Copy Markdown
Contributor
|
Lone failure appears unrelated, landing now. |
Sorry, something went wrong.
apapirovski
pushed a commit
that referenced
this pull request
Dec 8, 2017
PR-URL: #17494 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17494 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17494 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactored tests to replace assert.throws(fn, common.expectsError(err)); with common.expectsError(fn, err); in following test files :
Checklist
Affected core subsystem(s)
test