FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: replace assert.throws with common.expectsError by mithunsasidharan · Pull Request #17498 · nodejs/node · GitHub

/ node Public

test: replace assert.throws with common.expectsError - #17498

Closed
mithunsasidharan wants to merge 1 commit into
nodejs:masterfrom
mithunsasidharan:common_6
ConversationCommits (1)ChecksFiles changed
Closed

test: replace assert.throws with common.expectsError#17498
mithunsasidharan wants to merge 1 commit into
nodejs:masterfrom
mithunsasidharan:common_6

Conversation

mithunsasidharan commented Dec 6, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

Refactored tests to replace assert.throws(fn, common.expectsError(err)); with common.expectsError(fn, err);

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 6, 2017

mithunsasidharan commented Dec 6, 2017

Copy link
Copy Markdown
Contributor Author

@apapirovski @jasnell : Can I request if we could have this and other related PRs reviewed and landed sooner to avoid possible merge conflicts and changes resulting from other PRs ?

apapirovski commented Dec 6, 2017

Copy link
Copy Markdown
Contributor

This shouldn't be too likely to run into merge conflicts since it modifies pretty specific code. IMO it'll need the usual 48 hours to land. I'll review later today or tomorrow when I've got a moment.

mithunsasidharan commented Dec 6, 2017

Copy link
Copy Markdown
Contributor Author

@apapirovski : Thanks a lot. Here's ref to all 6 PRs related to this.. https://github.com/nodejs/node/pulls/mithunsasidharan

apapirovski approved these changes Dec 6, 2017
View reviewed changes

apapirovski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

SGTM if the CI is green

apapirovski commented Dec 6, 2017

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/11919/

mithunsasidharan commented Dec 8, 2017

Copy link
Copy Markdown
Contributor Author

@apapirovski : Can we have this and related PRs 17497, 17494,17484,17483 merged so that we can avoid potential merge conflict issues and its already been over 2 days ! Kindly advice. Thanks !

apapirovski commented Dec 8, 2017

Copy link
Copy Markdown
Contributor

@mithunsasidharan Please try to avoid pinging re: merging PRs. Someone will merge a PR if it's ready when they have a moment. As you'll note, there are over 180 open PRs and most of us are volunteers.

Also, strictly speaking only two of those PRs are over 48 hours old. This one still has another 4 hours to bake.

mithunsasidharan commented Dec 8, 2017

Copy link
Copy Markdown
Contributor Author

@apapirovski : My sincere apologies. It was out of excitement and intend to avoid any possible merge conflict. I will keep up with the rules. Thanks again !

apapirovski commented Dec 8, 2017

Copy link
Copy Markdown
Contributor

Would like to see a few more reviews for this so will wait to merge. If no one gets a chance to review in the next 24-48 hours, then will land as is.

maclover7 approved these changes Dec 8, 2017
View reviewed changes

maclover7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM, do your PRs cover all remaining assert.throws instances? Is there an ESLint rule that should be introduced here?

mithunsasidharan commented Dec 8, 2017

Copy link
Copy Markdown
Contributor Author

@maclover7 : The open PRs cover all remaining instances. Thanks !

apapirovski commented Dec 8, 2017

Copy link
Copy Markdown
Contributor

@maclover7 I have a lint rule ready (it's in one of the Code & Learn threads and my gist account), will introduce it when I have a moment.

apapirovski commented Dec 8, 2017

Copy link
Copy Markdown
Contributor

Landed in eae0c05

apapirovski closed this Dec 8, 2017
apapirovski pushed a commit that referenced this pull request Dec 8, 2017
test: replace assert.throws w/ common.expectsError
eae0c05 
PR-URL: #17498
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: replace assert.throws w/ common.expectsError
12903b4 
PR-URL: #17498
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
test: replace assert.throws w/ common.expectsError
d15cdc6 
PR-URL: #17498
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
MylesBorins mentioned this pull request Dec 12, 2017
Merged

gibfahn commented Dec 20, 2017

Copy link
Copy Markdown
Member

If someone would like to backport this to v8.x-staging and v6.x-staging, please follow the guide and raise backport PRs.

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
apapirovski apapirovski approved these changes
maclover7 maclover7 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL