doc: add missing URL argument types in fs.md - #18309
Closed
vsemozhetbyt wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
cjihrig
approved these changes
Jan 23, 2018
Copy link
Copy Markdown
Contributor
Author
|
Rebased, new CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/123/ |
Sorry, something went wrong.
joyeecheung
approved these changes
Jan 23, 2018
vsemozhetbyt
added a commit
that referenced
this pull request
Jan 23, 2018
PR-URL: #18309 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 30, 2018
PR-URL: #18309 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Feb 27, 2018
PR-URL: #18309 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Copy link
Copy Markdown
Contributor
|
I've landed this on 8.x and opted not to land on 6.x. Please lmk if this is erroneous |
Sorry, something went wrong.
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18309 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
This seems to be slipped in nodejs#18297 PR-URL: nodejs#18599 Refs: nodejs#18309 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc, fs
Refs:
fs.appendFile() -> fs.writeFile() -> fs.open() -> getPathFromURL()
fs.lchmod() ->fs.open() -> getPathFromURL()
fs.lchown() ->fs.open() -> getPathFromURL()
fs.truncate() ->fs.open() -> getPathFromURL()
fs.writeFile()-> fs.open() -> getPathFromURL()
fs.unwatchFile() -> getPathFromURL()