FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add missing URL types in fs promise API by vsemozhetbyt · Pull Request #18599 · nodejs/node · GitHub

/ node Public

doc: add missing URL types in fs promise API - #18599

Closed
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:doc-fs-promise-url
ConversationCommits (1)ChecksFiles changed
Closed

doc: add missing URL types in fs promise API#18599
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:doc-fs-promise-url

Conversation

vsemozhetbyt commented Feb 6, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc, fs

This seems to be slipped in #18297

Refs: #18309

cc @jasnell

nodejs-github-bot added doc Issues and PRs related to the documentations. fs Issues and PRs related to the fs subsystem / file system. labels Feb 6, 2018
vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 6, 2018

vsemozhetbyt commented Feb 6, 2018

Copy link
Copy Markdown
Contributor Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/150/

jasnell commented Feb 6, 2018

Copy link
Copy Markdown
Member

doh! thank you! I had seen but completely forgot about that comment in the original PR.

XadillaX approved these changes Feb 6, 2018
View reviewed changes

XadillaX left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm.

vsemozhetbyt commented Feb 6, 2018

Copy link
Copy Markdown
Contributor Author

Landed in ac829f0

vsemozhetbyt deleted the doc-fs-promise-url branch February 6, 2018 15:33
vsemozhetbyt added a commit that referenced this pull request Feb 6, 2018
doc: add missing URL types in fs promise API
ac829f0 
This seems to be slipped in #18297

PR-URL: #18599
Refs: #18309
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
doc: add missing URL types in fs promise API
ddfb1f1 
This seems to be slipped in nodejs#18297

PR-URL: nodejs#18599
Refs: nodejs#18309
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Khaidi Chu <i@2333.moe>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
cjihrig cjihrig approved these changes
+3 more reviewers
styfle styfle approved these changes
XadillaX XadillaX approved these changes
iwko iwko approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL