doc: linkify missing types - #18444
Closed
vsemozhetbyt wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Also, alphabetize all types in type-parser.js and fix some nits in type formats.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
I cannot understand what is wrong with linter job( |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
@vsemozhetbyt not your fault, see #18445 |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
lpinca
approved these changes
Jan 30, 2018
jasnell
approved these changes
Jan 31, 2018
vsemozhetbyt
added a commit
that referenced
this pull request
Feb 1, 2018
Also, alphabetize all types in type-parser.js and fix some nits in type formats. PR-URL: #18444 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
3 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Feb 20, 2018
Also, alphabetize all types in type-parser.js and fix some nits in type formats. PR-URL: #18444 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
Also, alphabetize all types in type-parser.js and fix some nits in type formats. PR-URL: #18444 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2018
Also, alphabetize all types in type-parser.js and fix some nits in type formats. PR-URL: #18444 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Copy link
Copy Markdown
Contributor
|
Should this be backported to v8.x-staging or v6.x-staging? If yes please follow the guide and raise a backport PR, if not let me know or add the dont-land-on label. |
Sorry, something went wrong.
3 tasks
3 tasks
Merged
Merged
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
Also, alphabetize all types in type-parser.js and fix some nits in type formats. PR-URL: nodejs#18444 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MayaLekova
pushed a commit
to MayaLekova/node
that referenced
this pull request
May 8, 2018
PR-URL: nodejs#18601 Refs: nodejs#18407 Refs: nodejs#18444 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc, tools
Also, alphabetize all types in type-parser.js and fix some nits in type formats.
Notes:
Custom types in type-parser.js were already grouped by module/subsystem, ASCII order being set inside each group.
I am not sure about 2 types: this (is it OK to link in this way?) and AsyncHook (we have no class chapter in the doc, so I've linked to the async_hooks.createHook() function which creates an instance; please, propose a better solution).
These types have been added (the rest of non-linkified types were just fixed according to the already available types):
{this} {AsyncHook} {crypto.constants} {Domain} {fs.Stats} {ClientHttp2Stream} {http2.Http2ServerRequest} {http2.Http2ServerResponse} {Http2Server} {Http2Session} {Http2Stream} {net.Server} {os.constants.dlopen} {PerformanceObserver} {PerformanceObserverEntryList} {readline.Interface} {Immediate} {Timeout} {tls.Server}