FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: add FileHandle to doc/type-parser.js by vsemozhetbyt · Pull Request #18601 · nodejs/node · GitHub

/ node Public

tools: add FileHandle to doc/type-parser.js - #18601

Closed
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:tools-type-parser-filehandle
ConversationCommits (1)ChecksFiles changed
Closed

tools: add FileHandle to doc/type-parser.js#18601
vsemozhetbyt wants to merge 1 commit into
nodejs:masterfrom
vsemozhetbyt:tools-type-parser-filehandle

Conversation

vsemozhetbyt commented Feb 6, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc, fs, tools

Refs: #18407
Refs: #18444

nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Feb 6, 2018
vsemozhetbyt added the fs Issues and PRs related to the fs subsystem / file system. label Feb 6, 2018

vsemozhetbyt commented Feb 6, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/154/

vsemozhetbyt added the fast-track PRs that do not need to wait for 48 hours to land. label Feb 6, 2018

vsemozhetbyt commented Feb 6, 2018

Copy link
Copy Markdown
Contributor Author

Do I understand correctly that CI failure is unrelated? Should we wait till "all green"?

apapirovski commented Feb 6, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

@vsemozhetbyt It is but I would suggest restarting it. Unless that box is down?

vsemozhetbyt commented Feb 6, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@apapirovski I will do, but I already restarted CI here and in another PR, it always fails recently, Maybe something wrong with machines.

New CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/156/

apapirovski commented Feb 6, 2018

Copy link
Copy Markdown
Contributor

@vsemozhetbyt I pinged @nodejs/build on IRC. Hopefully they can have a look.

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Feb 6, 2018

vsemozhetbyt commented Feb 6, 2018

Copy link
Copy Markdown
Contributor Author

New green CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite/157/

(possible fix: #18605)

vsemozhetbyt added a commit that referenced this pull request Feb 6, 2018
tools: add FileHandle to doc/type-parser.js
bff5d5b 
PR-URL: #18601
Refs: #18407
Refs: #18444
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

vsemozhetbyt commented Feb 6, 2018

Copy link
Copy Markdown
Contributor Author

Landed in bff5d5b

vsemozhetbyt deleted the tools-type-parser-filehandle branch February 6, 2018 22:29

MylesBorins commented Feb 21, 2018

Copy link
Copy Markdown
Contributor

With a quick look it appears this only applies to the promise fs apis, if mistaken please change labels and open a backport

MayaLekova pushed a commit to MayaLekova/node that referenced this pull request May 8, 2018
tools: add FileHandle to doc/type-parser.js
df2fb94 
PR-URL: nodejs#18601
Refs: nodejs#18407
Refs: nodejs#18444
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
BridgeAR BridgeAR approved these changes
+1 more reviewer
apapirovski apapirovski approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. fs Issues and PRs related to the fs subsystem / file system. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL