FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

module: fix stat with long paths on windows by Fishrock123 · Pull Request #2011 · nodejs/node · GitHub

/ node Public

module: fix stat with long paths on windows - #2011

Closed
Fishrock123 wants to merge 1 commit into
nodejs:masterfrom
Fishrock123:fix-module-long-path-windows
ConversationCommits (1)ChecksFiles changed
Closed

module: fix stat with long paths on windows#2011
Fishrock123 wants to merge 1 commit into
nodejs:masterfrom
Fishrock123:fix-module-long-path-windows

Conversation

Fishrock123 commented Jun 18, 2015

Copy link
Copy Markdown
Contributor

See https://github.com/nodejs/io.js/pull/1920/files#r32701699, this also requires the long path fix from #1991

Fishrock123 added the module Issues and PRs related to the module subsystem. label Jun 18, 2015
Fishrock123 mentioned this pull request Jun 18, 2015
Closed

bnoordhuis commented Jun 18, 2015

Copy link
Copy Markdown
Member

LGTM but a regression test would be nice.

targos commented Jun 18, 2015

Copy link
Copy Markdown
Member

this test I added in #1991 may be enough. I can try when I am back home.

targos commented Jun 18, 2015

Copy link
Copy Markdown
Member

or start a CI on master ? It will fail if I am right

ChALkeR commented Jun 18, 2015

Copy link
Copy Markdown
Member

I still think that it might be better to wrap internalModuleStat and internalModuleReadFile…

Fishrock123 commented Jun 18, 2015

Copy link
Copy Markdown
Contributor Author

CI on master: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/47/

targos commented Jun 18, 2015

Copy link
Copy Markdown
Member

@ChALkeR I agree. We can introduce internal/fs to expose the wrapped functions

mscdex added the windows Issues and PRs related to the Windows platform. label Jun 18, 2015

Fishrock123 commented Jun 18, 2015

Copy link
Copy Markdown
Contributor Author

CI on master does not appear to catch it?

ChALkeR mentioned this pull request Jun 18, 2015
Closed

targos commented Jun 18, 2015

Copy link
Copy Markdown
Member

apparently not 😞

vkurchatkin commented Jun 18, 2015

Copy link
Copy Markdown
Contributor

I still think that it might be better to wrap internalModuleStat and internalModuleReadFile…

+1

targos mentioned this pull request Jun 18, 2015
Closed

Fishrock123 commented Jun 19, 2015

Copy link
Copy Markdown
Contributor Author

#2013

gr00nd mentioned this pull request Feb 6, 2024
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

module Issues and PRs related to the module subsystem. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL