FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: allow tests to pass without internet by helio-frota · Pull Request #21909 · nodejs/node · GitHub

/ node Public

test: allow tests to pass without internet - #21909

Closed
helio-frota wants to merge 1 commit into
nodejs:masterfrom
helio-frota:internet-tests
ConversationCommits (1)ChecksFiles changed
Closed

test: allow tests to pass without internet#21909
helio-frota wants to merge 1 commit into
nodejs:masterfrom
helio-frota:internet-tests

Conversation

helio-frota commented Jul 20, 2018

Copy link
Copy Markdown
Contributor

Currently when running the test without an internet connection the following error appears:

=== release test-dns-promises-resolve ===                                      
Path: parallel/test-dns-promises-resolve
(node:12455) ExperimentalWarning: The dns.promises API is experimental
/opt/app-root/src/node/test/common/index.js:820
             (err) => process.nextTick(() => { throw err; }));
                                               ^

Error: queryA ETIMEOUT example.org
    at QueryReqWrap.onresolve [as oncomplete] (internal/dns/promises.js:163:17)
Command: out/Release/node /opt/app-root/src/node/test/parallel/test-dns-promises-resolve.js
[06:30|% 100|+ 2354|-   1]: Done                                               
make[1]: *** [jstest] Error 1
make: *** [test] Error 2
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

lance commented Jul 20, 2018

Copy link
Copy Markdown
Member

Please thumbs up here if you are OK with fast tracking this and i will land it.

lance commented Jul 20, 2018

Copy link
Copy Markdown
Member

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite/922/

richardlau commented Jul 20, 2018

Copy link
Copy Markdown
Member

Please thumbs up here if you are OK with fast tracking this and i will land it.

It's probably a good idea to run the internet suite of tests to make sure they're green seeing as they're not run as part of the regular CI.

Trott commented Jul 20, 2018

Copy link
Copy Markdown
Member

It's probably a good idea to run the internet suite of tests to make sure they're green seeing as they're not run as part of the regular CI.

Internet run: https://ci.nodejs.org/job/node-test-commit-custom-suites/138/

lance commented Jul 21, 2018

Copy link
Copy Markdown
Member

@Trott thanks for running those. I poked around CI when @richardlau mentioned running just one suite, and doing that was non-obvious.

After consulting the collaborator guide it was still non-obvious.

I know that due to my intermittent presence here, things can change. Is there any place this test suite is documented? After taking a look at the build job parameters it seems pretty straightforward. But, tbqh, I really didn't have any idea what to do when @richardlau mentioned it above.

lance commented Jul 21, 2018

Copy link
Copy Markdown
Member

Landed in 2058a1c

lance closed this Jul 21, 2018
lance pushed a commit that referenced this pull request Jul 21, 2018
test: allow tests to pass without internet
2058a1c 
PR-URL: #21909
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Trott mentioned this pull request Jul 21, 2018
Closed
3 tasks

Trott commented Jul 21, 2018

Copy link
Copy Markdown
Member

Is there any place this test suite is documented?

@lance #21927

targos pushed a commit that referenced this pull request Jul 21, 2018
test: allow tests to pass without internet
8191563 
PR-URL: #21909
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
helio-frota deleted the internet-tests branch July 21, 2018 20:22
Trott added a commit to Trott/io.js that referenced this pull request Jul 23, 2018
doc: add node-test-commit-custom-suites to docs
1a65fbc 
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE.

Refs: nodejs#21909 (comment)
Trott added a commit to Trott/io.js that referenced this pull request Jul 24, 2018
doc: add node-test-commit-custom-suites to docs
f5a2167 
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE.

Refs: nodejs#21909 (comment)

PR-URL: nodejs#21927
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Jul 26, 2018
doc: add node-test-commit-custom-suites to docs
96bb605 
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE.

Refs: #21909 (comment)

PR-URL: #21927
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos mentioned this pull request Jul 31, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
Closed
beevelop mentioned this pull request Aug 2, 2018
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
richardlau richardlau approved these changes
trivikr trivikr approved these changes
+1 more reviewer
lance lance approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL