FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: add node-test-commit-custom-suites to docs by Trott · Pull Request #21927 · nodejs/node · GitHub

/ node Public

doc: add node-test-commit-custom-suites to docs - #21927

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:internet-tests
ConversationCommits (1)ChecksFiles changed
Closed

doc: add node-test-commit-custom-suites to docs#21927
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:internet-tests

Conversation

Trott commented Jul 21, 2018

Copy link
Copy Markdown
Member

Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE.

Refs: #21909 (comment)

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

/ping @lance @maclover7

nodejs-github-bot commented Jul 21, 2018

Copy link
Copy Markdown
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/330/pipeline

Trott mentioned this pull request Jul 21, 2018
Closed
2 tasks
vsemozhetbyt added doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. meta Issues and PRs related to the general management of the project. labels Jul 21, 2018
lance approved these changes Jul 21, 2018
View reviewed changes

lance left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@Trott thanks!

richardlau reviewed Jul 21, 2018
View reviewed changes
Comment thread COLLABORATOR_GUIDE.md Outdated

richardlau Jul 21, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

While it is true that the default CI_JS_SUITES parameters to the job run internet the job is intended to run any test(suite) with custom arguments (I think you could even simulate the stress job by passing --repeat to TEST_ARGS).

Trott Jul 21, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I was trying to provide the minimum information to be useful. (I'd like to see pummel added FWIW.) If you have some alternate or additional text, do feel free to add it!

maclover7 mentioned this pull request Jul 22, 2018
Closed
3 tasks
maclover7 reviewed Jul 22, 2018
View reviewed changes
Comment thread COLLABORATOR_GUIDE.md Outdated

maclover7 Jul 22, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Not exactly... how about:

node-test-commit-custom-suites runs tests in user-specified directories with parameters provided by the user as well. Currently used on all node-test-commit jobs to run the default test suite with the --worker flag.

Trott Jul 23, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@maclover7 Updated. PTAL

doc: add node-test-commit-custom-suites to docs
1a65fbc 
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE.

Refs: nodejs#21909 (comment)
maclover7 approved these changes Jul 23, 2018
View reviewed changes

maclover7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

💯

Trott commented Jul 23, 2018

Copy link
Copy Markdown
Member Author

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/342/

Trott added a commit to Trott/io.js that referenced this pull request Jul 24, 2018
doc: add node-test-commit-custom-suites to docs
f5a2167 
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE.

Refs: nodejs#21909 (comment)

PR-URL: nodejs#21927
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Trott commented Jul 24, 2018

Copy link
Copy Markdown
Member Author

Landed in f5a2167

Trott closed this Jul 24, 2018
targos pushed a commit that referenced this pull request Jul 26, 2018
doc: add node-test-commit-custom-suites to docs
96bb605 
Add node-test-commit-custom-suites to the COLLABORATOR_GUIDE.

Refs: #21909 (comment)

PR-URL: #21927
Reviewed-By: Lance Ball <lball@redhat.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos mentioned this pull request Jul 31, 2018
Merged
This was referenced Aug 1, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Trott deleted the internet-tests branch January 13, 2022 22:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

richardlau richardlau approved these changes
trivikr trivikr approved these changes
+2 more reviewers
lance lance approved these changes
maclover7 maclover7 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL