lib: remove usc-2 encoding - #21964
Closed
mscdex wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
@mscdex build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/345/pipeline |
Sorry, something went wrong.
devsnek
approved these changes
Jul 25, 2018
ChALkeR
approved these changes
Jul 25, 2018
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. That looks to be introduced in 10.0 and removing it shouldn't affect any userland libs.
This should either land after #21965, or land with it, or should include benchmark changes here.
Sorry, something went wrong.
BridgeAR
approved these changes
Jul 25, 2018
Copy link
Copy Markdown
Member
|
I agree with @ChALkeR about either including that change here or landing the other PR first. |
Sorry, something went wrong.
benjamingr
approved these changes
Jul 25, 2018
mscdex
force-pushed
the
buffer-isencoding-fix
branch
from
58cdd86 to
fb50cf0
Compare
July 25, 2018 11:34
Copy link
Copy Markdown
Contributor
Author
|
I've included the benchmark changes now. New CI: https://ci.nodejs.org/job/node-test-pull-request/16002/ |
Sorry, something went wrong.
lpinca
approved these changes
Jul 25, 2018
addaleax
approved these changes
Jul 25, 2018
trivikr
approved these changes
Jul 27, 2018
cjihrig
approved these changes
Jul 27, 2018
jasnell
approved these changes
Jul 27, 2018
addaleax
pushed a commit
that referenced
this pull request
Jul 27, 2018
Fixes: #21963 PR-URL: #21964 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2018
Fixes: #21963 PR-URL: #21964 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Aug 1, 2018
This was referenced Aug 1, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #21963
CI: https://ci.nodejs.org/job/node-test-pull-request/16000/
Checklist