FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: Remove `usc-2` and `usc2` · Pull Request #21965 · nodejs/node · GitHub

/ node Public

test: Remove usc-2 and usc2 - #21965

Closed
ghost wants to merge 1 commit into
masterfrom
unknown repository
ConversationCommits (1)ChecksFiles changed
Closed

test: Remove usc-2 and usc2#21965
ghost wants to merge 1 commit into
masterfrom
unknown repository

Conversation

ghost commented Jul 25, 2018 •
edited by ghost
Loading

Copy link
Copy Markdown

Ref: #21963

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows [commit guidelines]

nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. util Issues and PRs related to the built-in util module. labels Jul 25, 2018
benjamingr approved these changes Jul 25, 2018
View reviewed changes

benjamingr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

cc @BridgeAR

benjamingr requested a review from BridgeAR July 25, 2018 07:42

BridgeAR commented Jul 25, 2018

Copy link
Copy Markdown
Member

This should land before #21964. Otherwise this change should be included directly in the mentioned PR.

silverwind commented Jul 25, 2018

Copy link
Copy Markdown
Contributor

#21964 is now a superset of this PR. I'd say we close this one.

ghost commented Jul 26, 2018

Copy link
Copy Markdown
Author

Since #21964 has added benchmark tests, so this is duplicated and close this.

ghost closed this Jul 26, 2018
ghost deleted the BufferSupportUSC2 branch July 26, 2018 01:16
ghost mentioned this pull request Aug 1, 2018
Merged
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

benchmark Issues and PRs related to the benchmark subsystem. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

Back | FazBrowse Home | New Git URL