FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

Doc Update : BufferwriteDoubleLE/writeDoubleBE by pranshuchittora · Pull Request #22170 · nodejs/node · GitHub

/ node Public

Doc Update : BufferwriteDoubleLE/writeDoubleBE - #22170

Closed
pranshuchittora wants to merge 1 commit into
nodejs:masterfrom
pranshuchittora:pranshuchittora
ConversationCommits (1)ChecksFiles changed
Closed

Doc Update : BufferwriteDoubleLE/writeDoubleBE#22170
pranshuchittora wants to merge 1 commit into
nodejs:masterfrom
pranshuchittora:pranshuchittora

Conversation

pranshuchittora commented Aug 7, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes : Documentation for BufferwriteDoubleLE/writeDoubleBE is confusing
#22158

  • documentation is changed or added

Doc Update -> BufferwriteDoubleLE/writeDoubleBE
30f7c6e 
Documentation for BufferwriteDoubleLE/writeDoubleBE is confusing 
#22158
nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Aug 7, 2018
pranshuchittora mentioned this pull request Aug 7, 2018
Closed

vsemozhetbyt commented Aug 7, 2018

Copy link
Copy Markdown
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

Trott commented Aug 9, 2018

Copy link
Copy Markdown
Member

CI lite again but rebased on master which hopefully has the fix for what was causing the failures: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/469/

vsemozhetbyt commented Aug 27, 2018

Copy link
Copy Markdown
Contributor

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/698/

vsemozhetbyt commented Aug 27, 2018

Copy link
Copy Markdown
Contributor

Sorry, I cannot understand why CI is so weird(

vsemozhetbyt mentioned this pull request Aug 28, 2018
Closed
2 tasks

pranshuchittora commented Aug 28, 2018

Copy link
Copy Markdown
Contributor Author

CI 😢
Its just a doc update checks can be ignored 👍

vsemozhetbyt reviewed Aug 29, 2018
View reviewed changes
Comment thread doc/api/buffer.md
// Prints: <Buffer 40 5e dd 2f 1a 9f be 77>

buf.writeDoubleLE(0xdeadbeefcafebabe, 0);

vsemozhetbyt Aug 29, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Linter issue:

  2152:1  error  More than 1 blank line not allowed  no-multiple-empty-lines

vsemozhetbyt commented Sep 2, 2018

Copy link
Copy Markdown
Contributor

@pranshuchittora Is it convenient for you to fix linter issue? If not, we can fix it on landing.

addaleax commented Sep 2, 2018

Copy link
Copy Markdown
Member

Landed in 9f7efd5 with commit message & linter fixed, thanks for the PR! 🎉

addaleax closed this Sep 2, 2018
addaleax pushed a commit that referenced this pull request Sep 2, 2018
doc: improve examples in buffer docs
9f7efd5 
Documentation for BufferwriteDoubleLE/writeDoubleBE is confusing

PR-URL: #22170
Fixes: #22158
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Sep 2, 2018
doc: improve examples in buffer docs
c00d113 
Documentation for BufferwriteDoubleLE/writeDoubleBE is confusing

PR-URL: #22170
Fixes: #22158
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos pushed a commit that referenced this pull request Sep 3, 2018
doc: improve examples in buffer docs
c7268c4 
Documentation for BufferwriteDoubleLE/writeDoubleBE is confusing

PR-URL: #22170
Fixes: #22158
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
doc: improve examples in buffer docs
a1f57f4 
Documentation for BufferwriteDoubleLE/writeDoubleBE is confusing

PR-URL: #22170
Fixes: #22158
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This was referenced Sep 6, 2018
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
lpinca lpinca approved these changes
BridgeAR BridgeAR approved these changes
+2 more reviewers
vsemozhetbyt vsemozhetbyt approved these changes
prog1dev prog1dev approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL