FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: specify ESLint rules being disabled in two files by Trott · Pull Request #22563 · nodejs/node · GitHub

/ node Public

tools: specify ESLint rules being disabled in two files - #22563

Closed
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:no-abusive-eslint-disable
ConversationCommits (2)ChecksFiles changed
Closed

tools: specify ESLint rules being disabled in two files#22563
Trott wants to merge 2 commits into
nodejs:masterfrom
Trott:no-abusive-eslint-disable

Conversation

Trott commented Aug 28, 2018

Copy link
Copy Markdown
Member

Instead of disabling all ESLint rules, just disable the rules necessary.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Trott added the tools Issues and PRs related to the tools directory. label Aug 28, 2018

nodejs-github-bot commented Aug 28, 2018

Copy link
Copy Markdown
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/710/pipeline

nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 28, 2018

Trott commented Aug 28, 2018

Copy link
Copy Markdown
Member Author

Can't seem to start a full CI at the moment, but perhaps the Lite CI is enough since this changes comments only, so linting is the thing to check?

Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 28, 2018

Trott commented Aug 28, 2018

Copy link
Copy Markdown
Member Author

Please 👍 here for fast-tracking.

vsemozhetbyt commented Aug 28, 2018

Copy link
Copy Markdown
Contributor

Something wrong with CI lite (rebasing?) happens now. In this PR CI lite has a wrong commit:

https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/710/

(In this PR last CI lite had many wrong commits: #22170)

Trott commented Aug 28, 2018

Copy link
Copy Markdown
Member Author

CI Lite re-run: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/714/pipeline

richardlau requested changes Aug 28, 2018
View reviewed changes
Comment thread test/parallel/test-assert.js Outdated

richardlau Aug 28, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

CI is failing because the message check in L701-L712 needs to be updated to match.

Trott Aug 29, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Argh! Fixed.

Comment thread test/parallel/test-assert.js Outdated

richardlau Aug 28, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

CI is failing because the message check in L725-L736 needs to be updated to match.

Trott Aug 29, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Also: Argh! Fixed.

Trott added 2 commits August 28, 2018 19:27
tools: specify rules disabled in common/dns.js
91727d3 
Instead of disabling all ESLint rules for a line, specify the two rules
that should be disabled.
tools: specify rule disabled in test-assert.js
26af2e5 
Instead of disabling all ESLint rules on two lines in test-assert.js,
specify the rule that needs to be disabled.
Trott force-pushed the no-abusive-eslint-disable branch from 9322ce3 to 26af2e5 Compare August 29, 2018 02:32

Trott commented Aug 29, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16846/

Trott commented Aug 31, 2018

Copy link
Copy Markdown
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16892/

BridgeAR added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 31, 2018

addaleax commented Aug 31, 2018

Copy link
Copy Markdown
Member

Landed in c5bd856, f86d0eb

addaleax closed this Aug 31, 2018
addaleax pushed a commit that referenced this pull request Aug 31, 2018
tools: specify rules disabled in common/dns.js
c5bd856 
Instead of disabling all ESLint rules for a line, specify the two rules
that should be disabled.

PR-URL: #22563
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit that referenced this pull request Aug 31, 2018
tools: specify rule disabled in test-assert.js
f86d0eb 
Instead of disabling all ESLint rules on two lines in test-assert.js,
specify the rule that needs to be disabled.

PR-URL: #22563
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit that referenced this pull request Aug 31, 2018
tools: specify rules disabled in common/dns.js
8235ef0 
Instead of disabling all ESLint rules for a line, specify the two rules
that should be disabled.

PR-URL: #22563
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit that referenced this pull request Aug 31, 2018
tools: specify rule disabled in test-assert.js
984a15d 
Instead of disabling all ESLint rules on two lines in test-assert.js,
specify the rule that needs to be disabled.

PR-URL: #22563
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 3, 2018
tools: specify rules disabled in common/dns.js
15b7f75 
Instead of disabling all ESLint rules for a line, specify the two rules
that should be disabled.

PR-URL: #22563
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 3, 2018
tools: specify rule disabled in test-assert.js
f5520cc 
Instead of disabling all ESLint rules on two lines in test-assert.js,
specify the rule that needs to be disabled.

PR-URL: #22563
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
tools: specify rules disabled in common/dns.js
b3e4a53 
Instead of disabling all ESLint rules for a line, specify the two rules
that should be disabled.

PR-URL: #22563
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
targos pushed a commit that referenced this pull request Sep 6, 2018
tools: specify rule disabled in test-assert.js
6df8426 
Instead of disabling all ESLint rules on two lines in test-assert.js,
specify the rule that needs to be disabled.

PR-URL: #22563
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This was referenced Sep 6, 2018
Closed
Closed
Trott deleted the no-abusive-eslint-disable branch October 10, 2021 01:39
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig approved these changes
richardlau richardlau approved these changes
BridgeAR BridgeAR approved these changes
trivikr trivikr approved these changes
+1 more reviewer
vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests. tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL