FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: replace _WG_ with _team_ by Trott · Pull Request #22183 · nodejs/node · GitHub

/ node Public

doc: replace _WG_ with _team_ - #22183

Closed
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:terminology
ConversationCommits (1)ChecksFiles changed
Closed

doc: replace _WG_ with _team_#22183
Trott wants to merge 1 commit into
nodejs:masterfrom
Trott:terminology

Conversation

Trott commented Aug 7, 2018

Copy link
Copy Markdown
Member

AFAICT, there is no N-API Working Group. There is an N-API team, but
AFAIK there is no charter etc. (And if I'm wrong and there is, then
https://nodejs.org/en/about/working-groups/ needs an update!)

Checklist

Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 7, 2018

nodejs-github-bot commented Aug 7, 2018

Copy link
Copy Markdown
Collaborator

@Trott build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/454/pipeline

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 7, 2018

Trott commented Aug 8, 2018 •
edited
Loading

Copy link
Copy Markdown
Member Author

Re-running lite job now that #22184 has landed.

Trott commented Aug 8, 2018

Copy link
Copy Markdown
Member Author

Oops, forgot the URL: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/457/pipeline

vsemozhetbyt commented Aug 8, 2018

Copy link
Copy Markdown
Contributor

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

Trott commented Aug 8, 2018

Copy link
Copy Markdown
Member Author

sigh and again: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/458/pipeline

Trott added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Aug 8, 2018
doc: replace _WG_ with _team_
dea2f90 
AFAICT, there is no N-API Working Group. There *is* an N-API team, but
AFAIK there is no charter etc. (And if I'm wrong and there is, then
https://nodejs.org/en/about/working-groups/ needs an update!)

Trott commented Aug 8, 2018

Copy link
Copy Markdown
Member Author

Hmmm...it appears that the lite-pipeline job may not rebase against master. So it's not picking up the recently-landed fix. Guess I'll rebase and force push and see if that helps things along...

Trott commented Aug 8, 2018

Copy link
Copy Markdown
Member Author

Lite CI: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/459/pipeline

Trott commented Aug 8, 2018

Copy link
Copy Markdown
Member Author

@nodejs/tsc @nodejs/n-api

mcollina approved these changes Aug 8, 2018
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

MylesBorins approved these changes Aug 8, 2018
View reviewed changes

MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Aug 8, 2018
doc: replace _WG_ with _team_
fcb46a4 
AFAICT, there is no N-API Working Group. There *is* an N-API team, but
AFAIK there is no charter etc. (And if I'm wrong and there is, then
https://nodejs.org/en/about/working-groups/ needs an update!)

PR-URL: nodejs#22183
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott commented Aug 8, 2018

Copy link
Copy Markdown
Member Author

Landed in fcb46a4

Trott closed this Aug 8, 2018
targos pushed a commit that referenced this pull request Aug 11, 2018
doc: replace _WG_ with _team_
99793b8 
AFAICT, there is no N-API Working Group. There *is* an N-API team, but
AFAIK there is no charter etc. (And if I'm wrong and there is, then
https://nodejs.org/en/about/working-groups/ needs an update!)

PR-URL: #22183
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
rvagg mentioned this pull request Aug 13, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Aug 16, 2018
Closed
Closed
Closed
Trott deleted the terminology branch January 13, 2022 22:50
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
doc: replace _WG_ with _team_
cea8d4f 
AFAICT, there is no N-API Working Group. There *is* an N-API team, but
AFAIK there is no charter etc. (And if I'm wrong and there is, then
https://nodejs.org/en/about/working-groups/ needs an update!)

PR-URL: nodejs/node#22183
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
lpinca lpinca approved these changes
cjihrig cjihrig approved these changes
+2 more reviewers
MylesBorins MylesBorins approved these changes
vsemozhetbyt vsemozhetbyt approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL