FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: update certificates and private keys by indutny · Pull Request #22184 · nodejs/node · GitHub

/ node Public

test: update certificates and private keys - #22184

Closed
indutny wants to merge 5 commits into
masterfrom
fix/ci-certs
ConversationCommits (5)ChecksFiles changed
Closed

test: update certificates and private keys#22184
indutny wants to merge 5 commits into
masterfrom
fix/ci-certs

Conversation

indutny commented Aug 7, 2018 •
edited by MylesBorins
Loading

Copy link
Copy Markdown
Member

The certificates in test fixtures were set to expire in 999 days since
they were generated. That time has passed, and they have to be reissued.
Bump expiration time to 9999 days for all of them to prevent this from
happening again in near future.

Fix: #22182

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

test: update certificates and private keys
111feb2 
The certificates in test fixtures were set to expire in 999 days since
they were generated. That time has passed, and they have to be reissued.
Bump expiration time to 9999 days for all of them to prevent this from
happening again in near future.

Fix: #22182

nodejs-github-bot commented Aug 7, 2018

Copy link
Copy Markdown
Collaborator

@indutny build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/455/pipeline

nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 7, 2018

indutny commented Aug 7, 2018

Copy link
Copy Markdown
Member Author

cc @MylesBorins @nodejs/crypto @bnoordhuis

indutny commented Aug 7, 2018
View reviewed changes
Comment thread test/fixtures/keys/Makefile Outdated
ca3-csr.pem: ca3.cnf ca3-key.pem
openssl req -new \
-extensions v3_ca \
-days 9999 \

indutny Aug 7, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Gosh, this slipped my quick review. It isn't really necessary, since the days are set in ca3.cnf.

MylesBorins Aug 7, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Should we remove it or just leave it?

indutny Aug 7, 2018

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Removed.

MylesBorins commented Aug 7, 2018

Copy link
Copy Markdown
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/16262/

MylesBorins commented Aug 7, 2018

Copy link
Copy Markdown
Contributor

@indutny no bueno

test.parallel/test-crypto-sign-verify
test.parallel/test-tls-cert-chains-concat
test.parallel/test-tls-cert-chains-in-ca
test.parallel/test-tls-multi-pfx
test.parallel/test-tls-peer-certificate

all failing

https://ci.nodejs.org/job/node-test-commit-linux/20522/nodes=alpine-latest-x64/

indutny commented Aug 8, 2018

Copy link
Copy Markdown
Member Author

Should be fixed now.

MylesBorins commented Aug 8, 2018

Copy link
Copy Markdown
Contributor

one more ci: https://ci.nodejs.org/job/node-test-pull-request/16263/

MylesBorins suggested changes Aug 8, 2018
View reviewed changes

MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

we should fast track this as it is breaking lots of things

MylesBorins approved these changes Aug 8, 2018
View reviewed changes

MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

😅

devsnek added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 8, 2018

jasnell commented Aug 8, 2018

Copy link
Copy Markdown
Member

I wonder if we shouldn't look at potentially dynamically generating these every so often

MylesBorins commented Aug 8, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

one last ci with sn extra 9... giving us 273 years to figure this out instead of 27

https://ci.nodejs.org/job/node-test-pull-request/16264/

jasnell commented Aug 8, 2018

Copy link
Copy Markdown
Member

Ah yes, good ole Node.js 557.0.0

MylesBorins commented Aug 8, 2018

Copy link
Copy Markdown
Contributor

@indutny still getting failures on arm

https://ci.nodejs.org/job/node-test-binary-arm/2608/RUN_SUBSET=5,label=pi3-docker/console

indutny commented Aug 8, 2018

Copy link
Copy Markdown
Member Author 
21:53:31     AssertionError [ERR_ASSERTION]: 5 2 agent3 rejected, but should NOT have been
21:53:31         at ChildProcess.<anonymous> (/home/iojs/build/workspace/node-test-binary-arm/test/parallel/test-tls-server-verify.js:232:14)
21:53:31         at ChildProcess.emit (events.js:182:13)
21:53:31         at Process.ChildProcess._handle.onexit (internal/child_process.js:240:12)

MylesBorins commented Aug 8, 2018

Copy link
Copy Markdown
Contributor

@mhdawson and I dug in a bunch and it seems like the failures on arm are infra related... potentially during setup

@rvagg can you dig into this?

One more ci: https://ci.nodejs.org/job/node-test-pull-request/16265/

landing if green

Trott approved these changes Aug 8, 2018
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Rubber-stamp LGTM if CI is green. +1 to fast-tracking

Trott commented Aug 8, 2018

Copy link
Copy Markdown
Member

parallel/test-tls-server-verify still failing on Raspberry Pi...

MylesBorins commented Aug 8, 2018

Copy link
Copy Markdown
Contributor

oops... I did the status file wrong

re-running arm https://ci.nodejs.org/job/node-test-commit-arm-fanned/2721/

rvagg mentioned this pull request Aug 8, 2018
Closed

rvagg commented Aug 8, 2018

Copy link
Copy Markdown
Member

Diagnosis & fix nodejs/build#1432
New CI run @ https://ci.nodejs.org/job/node-test-binary-arm/2612/ looking green.

MylesBorins pushed a commit that referenced this pull request Aug 8, 2018
test: update certificates and private keys
6efbe1a 
The certificates in test fixtures were set to expire in 999 days since
they were generated. That time has passed, and they have to be reissued.
Bump expiration time to 99999 days for all of them to prevent this from
happening again in near future.

PR-URL: #22184
Fixes: #22182
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

Trott commented Aug 8, 2018

Copy link
Copy Markdown
Member

Custom suites failed to git clone again. Re-running (again): https://ci.nodejs.org/job/node-test-commit-custom-suites/524/ (Not that it's relevant, since in node-daily-master, I'm pretty sure it only runs the internet suite.)

MylesBorins commented Aug 8, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Backporting to all staging branches

v11.x-staging 6efbe1a
v10.x-staging: a6b9ee9
v8.x-staging: 50ccfec
v6.x-staging: 14b46d0

Trott commented Aug 8, 2018

Copy link
Copy Markdown
Member

Unrelated flaky on LinuxONE, re-running: https://ci.nodejs.org/job/node-test-commit-linuxone/3652/

Trott commented Aug 8, 2018

Copy link
Copy Markdown
Member

Custom suites passed.

Trott mentioned this pull request Aug 8, 2018
Closed
2 tasks

Trott commented Aug 8, 2018

Copy link
Copy Markdown
Member

LinuxONE passed.

Trott commented Aug 8, 2018

Copy link
Copy Markdown
Member

Argh, the --worker custom suite run also failed. Re-run: https://ci.nodejs.org/job/node-test-commit-custom-suites/528/

Trott commented Aug 8, 2018

Copy link
Copy Markdown
Member

--worker custom suite re-run passed.

MylesBorins pushed a commit that referenced this pull request Aug 8, 2018
test: update certificates and private keys
50ccfec 
The certificates in test fixtures were set to expire in 999 days since
they were generated. That time has passed, and they have to be reissued.
Bump expiration time to 99999 days for all of them to prevent this from
happening again in near future.

PR-URL: #22184
Fixes: #22182
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins pushed a commit that referenced this pull request Aug 8, 2018
test: update certificates and private keys
14b46d0 
The certificates in test fixtures were set to expire in 999 days since
they were generated. That time has passed, and they have to be reissued.
Bump expiration time to 99999 days for all of them to prevent this from
happening again in near future.

PR-URL: #22184
Fixes: #22182
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
MylesBorins deleted the fix/ci-certs branch August 8, 2018 14:30
MylesBorins pushed a commit that referenced this pull request Aug 9, 2018
test: update certificates and private keys
0c9760d 
The certificates in test fixtures were set to expire in 999 days since
they were generated. That time has passed, and they have to be reissued.
Bump expiration time to 99999 days for all of them to prevent this from
happening again in near future.

PR-URL: #22184
Fixes: #22182
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
rvagg mentioned this pull request Aug 13, 2018
Merged
This was referenced Aug 16, 2018
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
MylesBorins mentioned this pull request Aug 17, 2018
Merged
firass111 pushed a commit to firass111/Project_node1 that referenced this pull request Apr 16, 2025
test: update certificates and private keys
e58c17b 
The certificates in test fixtures were set to expire in 999 days since
they were generated. That time has passed, and they have to be reissued.
Bump expiration time to 99999 days for all of them to prevent this from
happening again in near future.

PR-URL: nodejs/node#22184
Fixes: nodejs/node#22182
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
+3 more reviewers
rvagg rvagg approved these changes
MylesBorins MylesBorins approved these changes
devsnek devsnek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

parallel/test-tls-server-verify broken by crl in testing fixtures being expired

7 participants

Back | FazBrowse Home | New Git URL