FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

n-api: clean up thread-safe function by gabrielschulhof · Pull Request #22259 · nodejs/node · GitHub

/ node Public

n-api: clean up thread-safe function - #22259

Closed
gabrielschulhof wants to merge 1 commit into
nodejs:masterfrom
gabrielschulhof:cleanup-tsfn
ConversationCommits (1)ChecksFiles changed
Closed

n-api: clean up thread-safe function#22259
gabrielschulhof wants to merge 1 commit into
nodejs:masterfrom
gabrielschulhof:cleanup-tsfn

Conversation

gabrielschulhof commented Aug 11, 2018

Copy link
Copy Markdown
Contributor
  • Move class TsFn to name space v8impl
  • Remove NAPI_EXTERN from API declarations, because it's only needed
    in the header file.
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot commented Aug 11, 2018

Copy link
Copy Markdown
Collaborator

@gabrielschulhof build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/515/pipeline

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API. labels Aug 11, 2018
addaleax approved these changes Aug 22, 2018
View reviewed changes
Comment thread src/node_api.cc Outdated

addaleax Aug 22, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

style nits: I'd very much prefer to spell out ThreadSafeFunction, and we use spaces before the : in a class declaration

If you need abbreviations for individual functions, I think an using line might do the trick

jasnell Aug 23, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Yes, please avoid abbreviations

Comment thread src/node_api.cc Outdated

addaleax Aug 22, 2018

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

style nit: No space after []

Aside, we have make format-cpp (possibly preceded by make format-cpp-build), that should take care of style issues now :)

mhdawson approved these changes Aug 23, 2018
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM once @addaleax comments are addressed.

gabrielschulhof commented Aug 23, 2018

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16697/

@addaleax @mhdawson nits addressed.

gabrielschulhof commented Aug 23, 2018

Copy link
Copy Markdown
Contributor Author

Resumed as: https://ci.nodejs.org/job/node-test-pull-request/16702/

gabrielschulhof commented Aug 24, 2018

Copy link
Copy Markdown
Contributor Author

Another CI from the top: https://ci.nodejs.org/job/node-test-pull-request/16731/

addaleax mentioned this pull request Aug 25, 2018
Closed
4 tasks

gabrielschulhof commented Aug 25, 2018

Copy link
Copy Markdown
Contributor Author

Another CI: https://ci.nodejs.org/job/node-test-pull-request/16753/

n-api: clean up thread-safe function
2790896 
* Move class `TsFn` to name space `v8impl` and rename it to
  `ThreadSafeFunction`
* Remove `NAPI_EXTERN` from API declarations, because it's only needed
  in the header file.

gabrielschulhof commented Aug 28, 2018

Copy link
Copy Markdown
Contributor Author

Wow! git show --patience makes a huge difference!

gabrielschulhof commented Aug 28, 2018

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16829/

gabrielschulhof commented Aug 28, 2018

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/16834/

gabrielschulhof commented Aug 28, 2018

Copy link
Copy Markdown
Contributor Author

Resumed as https://ci.nodejs.org/job/node-test-pull-request/16837/

gabrielschulhof commented Aug 31, 2018

Copy link
Copy Markdown
Contributor Author

Another CI: https://ci.nodejs.org/job/node-test-pull-request/16902/

gabrielschulhof commented Aug 31, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Resumed as CI: https://ci.nodejs.org/job/node-test-pull-request/16915/ ✓

gabrielschulhof commented Aug 31, 2018

Copy link
Copy Markdown
Contributor Author

Landed in 403df7c.

gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Aug 31, 2018
n-api: clean up thread-safe function
403df7c 
* Move class `TsFn` to name space `v8impl` and rename it to
  `ThreadSafeFunction`
* Remove `NAPI_EXTERN` from API declarations, because it's only needed
  in the header file.

PR-URL: nodejs#22259
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
gabrielschulhof deleted the cleanup-tsfn branch August 31, 2018 19:54
targos pushed a commit that referenced this pull request Sep 1, 2018
n-api: clean up thread-safe function
aecf4e0 
* Move class `TsFn` to name space `v8impl` and rename it to
  `ThreadSafeFunction`
* Remove `NAPI_EXTERN` from API declarations, because it's only needed
  in the header file.

PR-URL: #22259
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
n-api: clean up thread-safe function
96213c8 
* Move class `TsFn` to name space `v8impl` and rename it to
  `ThreadSafeFunction`
* Remove `NAPI_EXTERN` from API declarations, because it's only needed
  in the header file.

PR-URL: #22259
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
targos mentioned this pull request Sep 5, 2018
Merged
targos pushed a commit that referenced this pull request Sep 6, 2018
n-api: clean up thread-safe function
cf1a020 
* Move class `TsFn` to name space `v8impl` and rename it to
  `ThreadSafeFunction`
* Remove `NAPI_EXTERN` from API declarations, because it's only needed
  in the header file.

PR-URL: #22259
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
This was referenced Sep 6, 2018
Closed
Closed
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Dec 28, 2018
n-api: clean up thread-safe function
35c6b1d 
* Move class `TsFn` to name space `v8impl` and rename it to
  `ThreadSafeFunction`
* Remove `NAPI_EXTERN` from API declarations, because it's only needed
  in the header file.

PR-URL: nodejs#22259
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this pull request Jan 18, 2019
n-api: clean up thread-safe function
a0fa101 
* Move class `TsFn` to name space `v8impl` and rename it to
  `ThreadSafeFunction`
* Remove `NAPI_EXTERN` from API declarations, because it's only needed
  in the header file.

Backport-PR-URL: #25002
PR-URL: #22259
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
n-api: clean up thread-safe function
902b079 
* Move class `TsFn` to name space `v8impl` and rename it to
  `ThreadSafeFunction`
* Remove `NAPI_EXTERN` from API declarations, because it's only needed
  in the header file.

Backport-PR-URL: #25002
PR-URL: #22259
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins mentioned this pull request Mar 26, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell left review comments
addaleax addaleax approved these changes
+2 more reviewers
kfarnung kfarnung approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL