n-api: remove idle_running from TsFn - #22520
Closed
ralphtheninja wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
The idle_running member variable in TsFn is always false and can therefore be removed.
ralphtheninja
force-pushed
the
napi-remove-idle-running
branch
from
c043d20 to
50e5a2d
Compare
August 25, 2018 11:16
Copy link
Copy Markdown
Member
|
I think this might have to be rebased after #22259 lands, as a heads up |
Sorry, something went wrong.
gabrielschulhof
approved these changes
Aug 26, 2018
devsnek
approved these changes
Aug 26, 2018
Copy link
Copy Markdown
Contributor
|
@addaleax I'll land this first, then land mine with a rebase. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
jasnell
approved these changes
Aug 27, 2018
Copy link
Copy Markdown
Author
|
Let me know if I should rebase it. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
Another CI run: https://ci.nodejs.org/job/node-test-pull-request/16794/ |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
CI resumed as: https://ci.nodejs.org/job/node-test-pull-request/16799/ (:heavy_check_mark:) |
Sorry, something went wrong.
addaleax
approved these changes
Aug 27, 2018
pull Bot
pushed a commit
to shakir-abdo/node
that referenced
this pull request
Aug 28, 2018
The idle_running member variable in TsFn is always false and can therefore be removed. PR-URL: nodejs#22520 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Gus Caplan <me@gus.host>
addaleax
pushed a commit
that referenced
this pull request
Aug 28, 2018
The idle_running member variable in TsFn is always false and can therefore be removed. PR-URL: #22520 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Gus Caplan <me@gus.host>
targos
pushed a commit
that referenced
this pull request
Sep 3, 2018
The idle_running member variable in TsFn is always false and can therefore be removed. PR-URL: #22520 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Gus Caplan <me@gus.host>
targos
pushed a commit
that referenced
this pull request
Sep 6, 2018
The idle_running member variable in TsFn is always false and can therefore be removed. PR-URL: #22520 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Gus Caplan <me@gus.host>
This was referenced Sep 6, 2018
gabrielschulhof
pushed a commit
to gabrielschulhof/node
that referenced
this pull request
Dec 28, 2018
The idle_running member variable in TsFn is always false and can therefore be removed. PR-URL: nodejs#22520 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Gus Caplan <me@gus.host>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 18, 2019
The idle_running member variable in TsFn is always false and can therefore be removed. Backport-PR-URL: #25002 PR-URL: #22520 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Gus Caplan <me@gus.host>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
The idle_running member variable in TsFn is always false and can therefore be removed. Backport-PR-URL: #25002 PR-URL: #22520 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com> Reviewed-By: Gus Caplan <me@gus.host>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The idle_running member variable in TsFn is always false and can
therefore be removed.
Checklist