FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: fix compiler warning in doc/api/addons.md by danbev · Pull Request #23323 · nodejs/node · GitHub

/ node Public

test: fix compiler warning in doc/api/addons.md - #23323

Closed
danbev wants to merge 2 commits into
nodejs:masterfrom
danbev:addon_compiler_tostring_compiler_warning
ConversationCommits (2)ChecksFiles changed
Closed

test: fix compiler warning in doc/api/addons.md#23323
danbev wants to merge 2 commits into
nodejs:masterfrom
danbev:addon_compiler_tostring_compiler_warning

Conversation

danbev commented Oct 8, 2018 •
edited
Loading

Copy link
Copy Markdown
Contributor

Currently the following compiler warning is emitted:

../addon.cc:17:58: warning: 'ToString' is deprecated: Use maybe version [-Wdeprecated-declarations]
  obj->Set(String::NewFromUtf8(isolate, "msg"), args[0]->ToString(isolate));
                                                         ^
./deps/v8/include/v8.h:2537:3: note: 'ToString' has been explicitly marked deprecated here
  V8_DEPRECATED("Use maybe version",
  ^

This commit updates example to use the non-deprecated version.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot commented Oct 8, 2018

Copy link
Copy Markdown
Collaborator

@danbev build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1163/pipeline

nodejs-github-bot added addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations. labels Oct 8, 2018
danbev force-pushed the addon_compiler_tostring_compiler_warning branch from f7e706c to 1b9a44e Compare October 8, 2018 05:33
danbev added 2 commits October 9, 2018 07:48
test: fix compiler warning in addons/02_callbacks
6e1fdb8 
Currently the following compiler warning is emitted:
../addon.cc:17:58:
warning: 'ToString' is deprecated:
Use maybe version [-Wdeprecated-declarations]
obj->Set(String::NewFromUtf8(isolate, "msg"),
                             args[0]->ToString(isolate));
                                                         ^
deps/v8/include/v8.h:2537:3:
note: 'ToString' has been explicitly marked deprecated here
  V8_DEPRECATED("Use maybe version",
  ^

This commit updates example to use the non-deprecated version.
squash: fix compiler warning 07_passing_wrapped_ob
0a0dc00 
Currently the following compiler warning is emitted:
1 warning generated.
../addon.cc:24:16:
warning: 'ToObject' is deprecated:
Use maybe version [-Wdeprecated-declarations]
      args[0]->ToObject(isolate));
               ^
./deps/v8/include/v8.h:2539:3:
note: 'ToObject' has been explicitly marked deprecated here
  V8_DEPRECATED("Use maybe version",
  ^

This commit updates example to use the non-deprecated version.
danbev force-pushed the addon_compiler_tostring_compiler_warning branch from 4f9e2dd to 0a0dc00 Compare October 9, 2018 05:49

danbev commented Oct 9, 2018

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/17699/

danbev mentioned this pull request Oct 10, 2018
Closed
4 tasks
danbev changed the title test: fix compiler warning in addons/02_callbacks test: fix compiler warning in doc/api/addons.md Oct 11, 2018
danbev added a commit that referenced this pull request Oct 11, 2018
test: fix compiler warning in doc/api/addons.md
59c7df4 
Currently there are compiler warnings is emitted:
../addon.cc:17:58:
warning: 'ToString' is deprecated:
Use maybe version [-Wdeprecated-declarations]
obj->Set(String::NewFromUtf8(isolate, "msg"),
                             args[0]->ToString(isolate));
                                                         ^
deps/v8/include/v8.h:2537:3:
note: 'ToString' has been explicitly marked deprecated here
  V8_DEPRECATED("Use maybe version",
  ^

This commit updates examples to use the non-deprecated versions.

PR-URL: #23323
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

danbev commented Oct 11, 2018

Copy link
Copy Markdown
Contributor Author

Landed in 59c7df4.

danbev closed this Oct 11, 2018
danbev deleted the addon_compiler_tostring_compiler_warning branch October 11, 2018 03:20
targos pushed a commit that referenced this pull request Oct 12, 2018
test: fix compiler warning in doc/api/addons.md
ebf04c1 
Currently there are compiler warnings is emitted:
../addon.cc:17:58:
warning: 'ToString' is deprecated:
Use maybe version [-Wdeprecated-declarations]
obj->Set(String::NewFromUtf8(isolate, "msg"),
                             args[0]->ToString(isolate));
                                                         ^
deps/v8/include/v8.h:2537:3:
note: 'ToString' has been explicitly marked deprecated here
  V8_DEPRECATED("Use maybe version",
  ^

This commit updates examples to use the non-deprecated versions.

PR-URL: #23323
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
jasnell pushed a commit that referenced this pull request Oct 17, 2018
test: fix compiler warning in doc/api/addons.md
e774d1b 
Currently there are compiler warnings is emitted:
../addon.cc:17:58:
warning: 'ToString' is deprecated:
Use maybe version [-Wdeprecated-declarations]
obj->Set(String::NewFromUtf8(isolate, "msg"),
                             args[0]->ToString(isolate));
                                                         ^
deps/v8/include/v8.h:2537:3:
note: 'ToString' has been explicitly marked deprecated here
  V8_DEPRECATED("Use maybe version",
  ^

This commit updates examples to use the non-deprecated versions.

PR-URL: #23323
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
test: fix compiler warning in doc/api/addons.md
dad3d74 
Currently there are compiler warnings is emitted:
../addon.cc:17:58:
warning: 'ToString' is deprecated:
Use maybe version [-Wdeprecated-declarations]
obj->Set(String::NewFromUtf8(isolate, "msg"),
                             args[0]->ToString(isolate));
                                                         ^
deps/v8/include/v8.h:2537:3:
note: 'ToString' has been explicitly marked deprecated here
  V8_DEPRECATED("Use maybe version",
  ^

This commit updates examples to use the non-deprecated versions.

PR-URL: #23323
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
test: fix compiler warning in doc/api/addons.md
858be85 
Currently there are compiler warnings is emitted:
../addon.cc:17:58:
warning: 'ToString' is deprecated:
Use maybe version [-Wdeprecated-declarations]
obj->Set(String::NewFromUtf8(isolate, "msg"),
                             args[0]->ToString(isolate));
                                                         ^
deps/v8/include/v8.h:2537:3:
note: 'ToString' has been explicitly marked deprecated here
  V8_DEPRECATED("Use maybe version",
  ^

This commit updates examples to use the non-deprecated versions.

PR-URL: #23323
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
test: fix compiler warning in doc/api/addons.md
7b4c4db 
Currently there are compiler warnings is emitted:
../addon.cc:17:58:
warning: 'ToString' is deprecated:
Use maybe version [-Wdeprecated-declarations]
obj->Set(String::NewFromUtf8(isolate, "msg"),
                             args[0]->ToString(isolate));
                                                         ^
deps/v8/include/v8.h:2537:3:
note: 'ToString' has been explicitly marked deprecated here
  V8_DEPRECATED("Use maybe version",
  ^

This commit updates examples to use the non-deprecated versions.

PR-URL: #23323
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
codebytere mentioned this pull request Nov 29, 2018
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
+1 more reviewer
thefourtheye thefourtheye approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL