FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix deprecation warnings from ToObject() in addons.md by oyyd · Pull Request #23401 · nodejs/node · GitHub

/ node Public

doc: fix deprecation warnings from ToObject() in addons.md - #23401

Closed
oyyd wants to merge 1 commit into
nodejs:masterfrom
oyyd:addon-tests
Closed

doc: fix deprecation warnings from ToObject() in addons.md#23401
oyyd wants to merge 1 commit into
nodejs:masterfrom
oyyd:addon-tests

Conversation

oyyd commented Oct 10, 2018

Copy link
Copy Markdown
Contributor

These code snippets are also used in addon tests.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

nodejs-github-bot added addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations. labels Oct 10, 2018
oyyd changed the title doc: fix deprecation warnings of ToObject() in addons.md doc: fix deprecation warnings from ToObject() in addons.md Oct 10, 2018
These code snippets are also used in addon tests.

danbev commented Oct 10, 2018

Copy link
Copy Markdown
Contributor

I think this might be a duplicate of #23323.

oyyd commented Oct 10, 2018

Copy link
Copy Markdown
Contributor Author

Yes. I didn't notice that. Will close.

oyyd closed this Oct 10, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addons Issues and PRs related to native addons. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants


Back | FazBrowse Home | New Git URL