FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix bug in MallocedBuffer by tniessen · Pull Request #23434 · nodejs/node · GitHub

/ node Public

src: fix bug in MallocedBuffer - #23434

Closed
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:src-fix-mallocedbuffer
ConversationCommits (1)ChecksFiles changed
Closed

src: fix bug in MallocedBuffer#23434
tniessen wants to merge 1 commit into
nodejs:masterfrom
tniessen:src-fix-mallocedbuffer

Conversation

tniessen commented Oct 12, 2018

Copy link
Copy Markdown
Member

This should be a generic type even though we are currently only using char as T.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

tniessen requested a review from addaleax October 12, 2018 00:05

nodejs-github-bot commented Oct 12, 2018

Copy link
Copy Markdown
Collaborator

@tniessen build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1209/pipeline

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Oct 12, 2018
thefourtheye approved these changes Oct 12, 2018
View reviewed changes

thefourtheye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Commit message has a typo and its very generic.

gireeshpunathil reviewed Oct 12, 2018
View reviewed changes
Comment thread src/util.h

addaleax commented Oct 12, 2018

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/17745/

Please 👍 this comment to approve fast-tracking.

addaleax added lib / src Issues and PRs related to general changes in the lib or src directory. fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. labels Oct 12, 2018

addaleax commented Oct 12, 2018

Copy link
Copy Markdown
Member

Landed in 714c1b8

addaleax closed this Oct 12, 2018
addaleax pushed a commit that referenced this pull request Oct 12, 2018
src: fix bug in MallocedBuffer constructor
714c1b8 
This should be a generic type even though we are
currently only using `char` as `T`.

PR-URL: #23434
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott pushed a commit that referenced this pull request Oct 13, 2018
src: fix bug in MallocedBuffer constructor
2218a38 
This should be a generic type even though we are
currently only using `char` as `T`.

PR-URL: #23434
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 13, 2018
src: fix bug in MallocedBuffer constructor
678019c 
This should be a generic type even though we are
currently only using `char` as `T`.

PR-URL: #23434
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
refack mentioned this pull request Oct 13, 2018
Closed
2 tasks
refack mentioned this pull request Oct 13, 2018
Closed
2 tasks
refack added a commit to refack/node that referenced this pull request Oct 13, 2018
src: refacor MallocedBuffer to it's usage scope
d16f098 
Ref: nodejs#23543 (review)
Ref: nodejs#23434
refack mentioned this pull request Oct 13, 2018
Closed
3 tasks
refack added a commit to refack/node that referenced this pull request Oct 13, 2018
src: malloced_unique_ptr & make_malloced_unique
bca838b 
Ref: nodejs#23641
Ref: nodejs#23543 (review)
Ref: nodejs#23434
refack mentioned this pull request Oct 13, 2018
Closed
3 tasks
jasnell pushed a commit that referenced this pull request Oct 17, 2018
src: fix bug in MallocedBuffer constructor
ecacf33 
This should be a generic type even though we are
currently only using `char` as `T`.

PR-URL: #23434
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
refack added a commit to refack/node that referenced this pull request Oct 20, 2018
src: malloced_unique_ptr & make_malloced_unique
5bd49eb 
Ref: nodejs#23641
Ref: nodejs#23543 (review)
Ref: nodejs#23434
MylesBorins pushed a commit that referenced this pull request Oct 30, 2018
src: fix bug in MallocedBuffer constructor
8cd41aa 
This should be a generic type even though we are
currently only using `char` as `T`.

PR-URL: #23434
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere mentioned this pull request Nov 27, 2018
Closed
rvagg pushed a commit that referenced this pull request Nov 28, 2018
src: fix bug in MallocedBuffer constructor
0d3364d 
This should be a generic type even though we are
currently only using `char` as `T`.

PR-URL: #23434
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 29, 2018
src: fix bug in MallocedBuffer constructor
a663d56 
This should be a generic type even though we are
currently only using `char` as `T`.

PR-URL: #23434
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
codebytere mentioned this pull request Nov 29, 2018
Merged
tniessen removed the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Jan 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

addaleax addaleax approved these changes
jasnell jasnell approved these changes
gireeshpunathil gireeshpunathil approved these changes
+2 more reviewers
refack refack approved these changes
thefourtheye thefourtheye approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL